Changeset 47588

Timestamp:

04/16/2020 05:00:58 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing.

Props roytanck, shooper.
Fixes #49916.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (10 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -530 +530 @@
                 $actions['update-selected'] = __( 'Update' );
             }
+
             if ( current_user_can( 'delete_plugins' ) && ( 'active' != $status ) ) {
                 $actions['delete-selected'] = __( 'Delete' );
@@ -621 +622 @@
 
         list( $plugin_file, $plugin_data ) = $item;
-        $context                           = $status;
-        $screen                            = $this->screen;
+
+        $plugin_slug = isset( $plugin_data['slug'] ) ? $plugin_data['slug'] : sanitize_title( $plugin_data['Name'] );
+
+        $context = $status;
+        $screen  = $this->screen;
 
         // Pre-order.
@@ -676 +680 @@
                     if ( current_user_can( 'manage_network_plugins' ) ) {
                         $actions['deactivate'] = sprintf(
-                            '<a href="%s" aria-label="%s">%s</a>',
+                            '<a href="%s" id="deactivate-%s" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=deactivate&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'deactivate-plugin_' . $plugin_file ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Network Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -686 +691 @@
                     if ( current_user_can( 'manage_network_plugins' ) ) {
                         $actions['activate'] = sprintf(
-                            '<a href="%s" class="edit" aria-label="%s">%s</a>',
+                            '<a href="%s" id="activate-%s" class="edit" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'activate-plugin_' . $plugin_file ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Network Activate %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -693 +699 @@
                         );
                     }
+
                     if ( current_user_can( 'delete_plugins' ) && ! is_plugin_active( $plugin_file ) ) {
                         $actions['delete'] = sprintf(
-                            '<a href="%s" class="delete" aria-label="%s">%s</a>',
+                            '<a href="%s" id="delete-%s" class="delete" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=delete-selected&amp;checked[]=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'bulk-plugins' ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Delete %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -715 +723 @@
                     if ( current_user_can( 'deactivate_plugin', $plugin_file ) ) {
                         $actions['deactivate'] = sprintf(
-                            '<a href="%s" aria-label="%s">%s</a>',
+                            '<a href="%s" id="deactivate-%s" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=deactivate&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'deactivate-plugin_' . $plugin_file ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -722 +731 @@
                         );
                     }
+
                     if ( current_user_can( 'resume_plugin', $plugin_file ) && is_plugin_paused( $plugin_file ) ) {
                         $actions['resume'] = sprintf(
-                            '<a class="resume-link" href="%s" aria-label="%s">%s</a>',
+                            '<a href="%s" id="resume-%s" class="resume-link" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=resume&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'resume-plugin_' . $plugin_file ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Resume %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -734 +745 @@
                     if ( current_user_can( 'activate_plugin', $plugin_file ) ) {
                         $actions['activate'] = sprintf(
-                            '<a href="%s" class="edit" aria-label="%s">%s</a>',
+                            '<a href="%s" id="activate-%s" class="edit" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'activate-plugin_' . $plugin_file ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Activate %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -744 +756 @@
                     if ( ! is_multisite() && current_user_can( 'delete_plugins' ) ) {
                         $actions['delete'] = sprintf(
-                            '<a href="%s" class="delete" aria-label="%s">%s</a>',
+                            '<a href="%s" id="delete-%s" class="delete" aria-label="%s">%s</a>',
                             wp_nonce_url( 'plugins.php?action=delete-selected&amp;checked[]=' . urlencode( $plugin_file ) . '&amp;plugin_status=' . $context . '&amp;paged=' . $page . '&amp;s=' . $s, 'bulk-plugins' ),
+                            esc_attr( $plugin_slug ),
                             /* translators: %s: Plugin name. */
                             esc_attr( sprintf( _x( 'Delete %s', 'plugin' ), $plugin_data['Name'] ) ),
@@ -861 +874 @@
         }
 
-        $plugin_slug = isset( $plugin_data['slug'] ) ? $plugin_data['slug'] : sanitize_title( $plugin_name );
         printf(
             '<tr class="%s" data-slug="%s" data-plugin="%s">',