Changeset 47617 for trunk/src/wp-includes/class-wp-http-proxy.php

Timestamp:

04/24/2020 07:26:57 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove error suppression from parse_url() calls.

Previously, the @ operator was used to prevent possible warnings emitted by parse_url() in PHP < 5.3.3 when URL parsing failed.

Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.

Props netpassprodsr, Howdy_McGee.
Fixes #49980. See #24780.

File:

• trunk/src/wp-includes/class-wp-http-proxy.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-http-proxy.php

@@ -168 +168 @@
      */
     public function send_through_proxy( $uri ) {
-        /*
-         * parse_url() only handles http, https type URLs, and will emit E_WARNING on failure.
-         * This will be displayed on sites, which is not reasonable.
-         */
-        $check = @parse_url( $uri );
+        $check = parse_url( $uri );
 
         // Malformed URL, can not process, but this could mean ssl, so let through anyway.