Changeset 47617 for trunk/src/wp-includes/comment.php

Timestamp:

04/24/2020 07:26:57 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove error suppression from parse_url() calls.

Previously, the @ operator was used to prevent possible warnings emitted by parse_url() in PHP < 5.3.3 when URL parsing failed.

Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.

Props netpassprodsr, Howdy_McGee.
Fixes #49980. See #24780.

File:

• trunk/src/wp-includes/comment.php (modified) (2 diffs)

trunk/src/wp-includes/comment.php

@@ -581 +581 @@
      */
     $comment_cookie_lifetime = time() + apply_filters( 'comment_cookie_lifetime', 30000000 );
-    $secure                  = ( 'https' === parse_url( home_url(), PHP_URL_SCHEME ) );
+
+    $secure = ( 'https' === parse_url( home_url(), PHP_URL_SCHEME ) );
+
     setcookie( 'comment_author_' . COOKIEHASH, $comment->comment_author, $comment_cookie_lifetime, COOKIEPATH, COOKIE_DOMAIN, $secure );
     setcookie( 'comment_author_email_' . COOKIEHASH, $comment->comment_author_email, $comment_cookie_lifetime, COOKIEPATH, COOKIE_DOMAIN, $secure );
@@ -2853 +2855 @@
         // If we haven't pung it already and it isn't a link to itself.
         if ( ! in_array( $link_test, $pung, true ) && ( url_to_postid( $link_test ) != $post->ID )
-                // Also, let's never ping local attachments.
-                && ! is_local_attachment( $link_test ) ) {
-            $test = @parse_url( $link_test );
+            // Also, let's never ping local attachments.
+            && ! is_local_attachment( $link_test )
+        ) {
+            $test = parse_url( $link_test );
             if ( $test ) {
                 if ( isset( $test['query'] ) ) {