Changeset 47617 for trunk/src/wp-includes/http.php

Timestamp:

04/24/2020 07:26:57 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove error suppression from parse_url() calls.

Previously, the @ operator was used to prevent possible warnings emitted by parse_url() in PHP < 5.3.3 when URL parsing failed.

Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.

Props netpassprodsr, Howdy_McGee.
Fixes #49980. See #24780.

File:

• trunk/src/wp-includes/http.php (modified) (4 diffs)

trunk/src/wp-includes/http.php

@@ -523 +523 @@
     }
 
-    $parsed_url = @parse_url( $url );
+    $parsed_url = parse_url( $url );
     if ( ! $parsed_url || empty( $parsed_url['host'] ) ) {
         return false;
@@ -536 +536 @@
     }
 
-    $parsed_home = @parse_url( get_option( 'home' ) );
+    $parsed_home = parse_url( get_option( 'home' ) );
 
     if ( isset( $parsed_home['host'] ) ) {
@@ -655 +655 @@
  * differences as well.
  *
- * Error suppression is used as prior to PHP 5.3.3, an E_WARNING would be generated
- * when URL parsing failed.
- *
  * @since 4.4.0
  * @since 4.7.0 The `$component` parameter was added for parity with PHP's `parse_url()`.
@@ -685 +682 @@
     }
 
-    $parts = @parse_url( $url );
+    $parts = parse_url( $url );
 
     if ( false === $parts ) {