Changeset 47661 for branches/3.8/tests/phpunit/tests/formatting/SanitizeFileName.php

Timestamp:

04/29/2020 04:57:01 PM (6 years ago)

Author:

whyisjake

Message:

User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand sanitize_file_name to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 3.8 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.

Location:

branches/3.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/formatting/SanitizeFileName.php (modified) (1 diff)

branches/3.8/tests/phpunit/tests/formatting/SanitizeFileName.php

@@ -43 +43 @@
                 $this->assertEquals( 'no-extension', sanitize_file_name( '_.no-extension' ) );
         }
+
+        /**
+         * @dataProvider data_wp_filenames
+         */
+        function test_replaces_invalid_utf8_characters( $input, $expected ) {
+                $this->assertEquals( $expected, sanitize_file_name( $input ) );
+        }
+
+        function data_wp_filenames() {
+                return array(
+                        array( urldecode( '%B1myfile.png' ), 'myfile.png' ),
+                        array( urldecode( '%B1myfile' ), 'myfile' ),
+                        array( 'demo bar.png', 'demo-bar.png' ),
+                        array( 'demo' . json_decode( '"\u00a0"' ) . 'bar.png', 'demo-bar.png' ),
+                );
+        }
 }