Changeset 47735 for trunk/phpcompat.xml.dist

Timestamp:

05/01/2020 07:05:04 PM (4 years ago)

Author:

desrosj

Message:

General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.

As part of the continued effort to improve PHP compatibility, the following improvments are being made:

• Removing deprecated PHP safe_mode checks not found in bundled external libraries.
• Change the remaining while loops using each() to foreach loops.
• Prevent false positives from being flagged for the sodium_compat library being caused by loading this in a non-standard way.
• Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.

File:

• trunk/phpcompat.xml.dist (modified) (1 diff)

trunk/phpcompat.xml.dist

@@ -42 +42 @@
 
     <!--
+        PHPCompatibilityParagonieSodiumCompat prevents false positives in `sodium_compat`.
+        However, because these files are included in a non-standard path, false positives are triggered in WordPress Core.
+    -->
+    <exclude-pattern>src/wp-includes/sodium_compat/lib/php72compat_const\.php$</exclude-pattern>
+
+    <rule ref="PHPCompatibility.FunctionUse.NewFunctions.sodium_crypto_sign_keypair_from_secretkey_and_publickeyFound">
+        <exclude-pattern>/sodium_compat/src/Compat\.php$</exclude-pattern>
+    </rule>
+    <rule ref="PHPCompatibility.FunctionUse.NewFunctions.sodium_padFound">
+        <exclude-pattern>/sodium_compat/src/Compat\.php$</exclude-pattern>
+    </rule>
+    <rule ref="PHPCompatibility.FunctionUse.NewFunctions.sodium_unpadFound">
+        <exclude-pattern>/sodium_compat/src/Compat\.php$</exclude-pattern>
+    </rule>
+
+    <!--
         PHPCompatibilityParagonieRandomCompat prevents false positives in `random_compat`.
         However, because these files are included in a non-standard path, false positives are triggered in WordPress Core.