Changeset 47735 for trunk/src/wp-admin/includes/schema.php

Timestamp:

05/01/2020 07:05:04 PM (5 years ago)

Author:

desrosj

Message:

General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.

As part of the continued effort to improve PHP compatibility, the following improvments are being made:

• Removing deprecated PHP safe_mode checks not found in bundled external libraries.
• Change the remaining while loops using each() to foreach loops.
• Prevent false positives from being flagged for the sodium_compat library being caused by loading this in a non-standard way.
• Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.

File:

• trunk/src/wp-admin/includes/schema.php (modified) (2 diffs)

trunk/src/wp-admin/includes/schema.php

@@ -370 +370 @@
     do_action( 'populate_options' );
 
-    if ( ini_get( 'safe_mode' ) ) {
-        // Safe mode can break mkdir() so use a flat structure by default.
-        $uploads_use_yearmonth_folders = 0;
-    } else {
-        $uploads_use_yearmonth_folders = 1;
-    }
-
     // If WP_DEFAULT_THEME doesn't exist, fall back to the latest core default theme.
     $stylesheet = WP_DEFAULT_THEME;
@@ -467 +460 @@
 
         // 2.0.1
-        'uploads_use_yearmonth_folders'   => $uploads_use_yearmonth_folders,
+        'uploads_use_yearmonth_folders'   => 1,
         'upload_path'                     => '',