Changeset 47735 for trunk/src/wp-includes/ID3/getid3.php

Timestamp:

05/01/2020 07:05:04 PM (5 years ago)

Author:

desrosj

Message:

General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.

As part of the continued effort to improve PHP compatibility, the following improvments are being made:

• Removing deprecated PHP safe_mode checks not found in bundled external libraries.
• Change the remaining while loops using each() to foreach loops.
• Prevent false positives from being flagged for the sodium_compat library being caused by loading this in a non-standard way.
• Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.

File:

• trunk/src/wp-includes/ID3/getid3.php (modified) (4 diffs)

trunk/src/wp-includes/ID3/getid3.php

@@ -286 +286 @@
 
         // Check safe_mode off
-        if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) {
+        if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) { // phpcs:ignore  // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_runtimeDeprecated
             $this->warning('WARNING: Safe mode is on, shorten support disabled, md5data/sha1data for ogg vorbis disabled, ogg vorbos/flac tag writing disabled.');
         }
@@ -301 +301 @@
             // Check for magic_quotes_runtime
             if (function_exists('get_magic_quotes_runtime')) {
-                if (get_magic_quotes_runtime()) {
+                if (get_magic_quotes_runtime()) { // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_runtimeDeprecated
                     $this->startup_error .= 'magic_quotes_runtime must be disabled before running getID3(). Surround getid3 block by set_magic_quotes_runtime(0) and set_magic_quotes_runtime(1).'."\n";
                 }
@@ -307 +307 @@
             // Check for magic_quotes_gpc
             if (function_exists('get_magic_quotes_gpc')) {
-                if (get_magic_quotes_gpc()) {
+                if (get_magic_quotes_gpc()) { // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_gpcDeprecated
                     $this->startup_error .= 'magic_quotes_gpc must be disabled before running getID3(). Surround getid3 block by set_magic_quotes_gpc(0) and set_magic_quotes_gpc(1).'."\n";
                 }
@@ -1561 +1561 @@
             // currently vorbiscomment only works on OggVorbis files.
 
-            if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) {
+            if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) { // phpcs:ignore  // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_runtimeDeprecated
 
                 $this->warning('Failed making system call to vorbiscomment.exe - '.$algorithm.'_data is incorrect - error returned: PHP running in Safe Mode (backtick operator not available)');