Changeset 47745

Timestamp:

05/02/2020 08:59:31 PM (5 years ago)

Author:

johnbillion

Message:

Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu.

Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal

Fixes #35155

Location:

trunk/src/wp-admin

Files:

• admin-header.php (modified) (1 diff)
• css/admin-menu.css (modified) (1 diff)

trunk/src/wp-admin/admin-header.php

@@ -199 +199 @@
         $admin_body_class .= ' is-dark-theme';
     }
+}
+
+// Print a CSS class to make PHP errors visible.
+if ( error_get_last() && WP_DEBUG && WP_DEBUG_DISPLAY && ini_get( 'display_errors' ) ) {
+    $admin_body_class .= ' php-error';
 }
 

trunk/src/wp-admin/css/admin-menu.css

@@ -12 +12 @@
     bottom: -120px;
     z-index: 1; /* positive z-index to avoid elastic scrolling woes in Safari */
+}
+
+.php-error #adminmenuback {
+    position: absolute;
+}
+
+.php-error #adminmenuback,
+.php-error #adminmenuwrap {
+    margin-top: 2em;
 }