Changeset 47756

Timestamp:

05/03/2020 10:56:01 PM (6 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Accept POST requests in the block renderer endpoint.

Rendering a block is idempotent, so a GET is the most natural request method. However, the maximum length of URLs prevented blocks with large attributes from being rendered.

Props ryankienstra.
Fixes #49680.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-block-renderer-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-block-renderer-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-block-renderer-controller.php

@@ -53 +53 @@
                                         ),
                                         array(
-                                                'methods'             => WP_REST_Server::READABLE,
+                                                'methods'             => array( WP_REST_Server::READABLE, WP_REST_Server::CREATABLE ),
                                                 'callback'            => array( $this, 'get_item' ),
                                                 'permission_callback' => array( $this, 'get_item_permissions_check' ),

trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

@@ -457 +457 @@
 
         /**
+         * Test a POST request, with the attributes in the body.
+         *
+         * @ticket 49680
+         */
+        public function test_get_item_post_request() {
+                wp_set_current_user( self::$user_id );
+                $string_attribute = 'Lorem ipsum dolor';
+                $attributes       = array( 'some_string' => $string_attribute );
+                $request          = new WP_REST_Request( 'POST', self::$rest_api_route . self::$block_name );
+                $request->set_param( 'context', 'edit' );
+                $request->set_header( 'content-type', 'application/json' );
+                $request->set_body( wp_json_encode( compact( 'attributes' ) ) );
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertEquals( 200, $response->get_status() );
+                $this->assertContains( $string_attribute, $response->get_data()['rendered'] );
+        }
+
+        /**
          * Test getting item with invalid post ID.
          *
@@ -504 +523 @@
                 $data     = $response->get_data();
 
-                $this->assertEqualSets( array( 'GET' ), $data['endpoints'][0]['methods'] );
+                $this->assertEqualSets( array( 'GET', 'POST' ), $data['endpoints'][0]['methods'] );
                 $this->assertEqualSets(
                         array( 'name', 'context', 'attributes', 'post_id' ),