Changeset 47778

Timestamp:

05/09/2020 12:50:43 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Fix WPCS issues in wp-includes/update.php.

Props mukesh27.
Fixes #50130.

File:

• trunk/src/wp-includes/update.php (modified) (29 diffs)

trunk/src/wp-includes/update.php

@@ -23 +23 @@
  */
 function wp_version_check( $extra_stats = array(), $force_check = false ) {
+    global $wpdb, $wp_local_package;
+
     if ( wp_installing() ) {
         return;
     }
 
-    global $wpdb, $wp_local_package;
     // Include an unmodified $wp_version.
     require ABSPATH . WPINC . '/version.php';
@@ -36 +37 @@
 
     // Invalidate the transient when $wp_version changes.
-    if ( is_object( $current ) && $wp_version != $current->version_checked ) {
+    if ( is_object( $current ) && $wp_version !== $current->version_checked ) {
         $current = false;
     }
@@ -53 +54 @@
     $timeout          = MINUTE_IN_SECONDS;
     $time_not_changed = isset( $current->last_checked ) && $timeout > ( time() - $current->last_checked );
+
     if ( ! $force_check && $time_not_changed ) {
         return;
@@ -136 +138 @@
     $http_url = $url;
     $ssl      = wp_http_supports( array( 'ssl' ) );
+
     if ( $ssl ) {
         $url = set_url_scheme( $url, 'https' );
@@ -153 +156 @@
 
     $response = wp_remote_post( $url, $options );
+
     if ( $ssl && is_wp_error( $response ) ) {
         trigger_error(
@@ -165 +169 @@
     }
 
-    if ( is_wp_error( $response ) || 200 != wp_remote_retrieve_response_code( $response ) ) {
+    if ( is_wp_error( $response ) || 200 !== wp_remote_retrieve_response_code( $response ) ) {
         return;
     }
@@ -180 +184 @@
     foreach ( $offers as &$offer ) {
         foreach ( $offer as $offer_key => $value ) {
-            if ( 'packages' == $offer_key ) {
+            if ( 'packages' === $offer_key ) {
                 $offer['packages'] = (object) array_intersect_key(
                     array_map( 'esc_url', $offer['packages'] ),
                     array_fill_keys( array( 'full', 'no_content', 'new_bundled', 'partial', 'rollback' ), '' )
                 );
-            } elseif ( 'download' == $offer_key ) {
+            } elseif ( 'download' === $offer_key ) {
                 $offer['download'] = esc_url( $value );
             } else {
@@ -227 +231 @@
     if ( ! empty( $body['ttl'] ) ) {
         $ttl = (int) $body['ttl'];
+
         if ( $ttl && ( time() + $ttl < wp_next_scheduled( 'wp_version_check' ) ) ) {
             // Queue an event to re-run the update check in $ttl seconds.
@@ -274 +279 @@
     $active  = get_option( 'active_plugins', array() );
     $current = get_site_transient( 'update_plugins' );
+
     if ( ! is_object( $current ) ) {
         $current = new stdClass;
@@ -307 +313 @@
     if ( $time_not_changed && ! $extra_stats ) {
         $plugin_changed = false;
+
         foreach ( $plugins as $file => $p ) {
             $new_option->checked[ $file ] = $p['Version'];
@@ -374 +381 @@
     $http_url = $url;
     $ssl      = wp_http_supports( array( 'ssl' ) );
+
     if ( $ssl ) {
         $url = set_url_scheme( $url, 'https' );
@@ -379 +387 @@
 
     $raw_response = wp_remote_post( $url, $options );
+
     if ( $ssl && is_wp_error( $raw_response ) ) {
         trigger_error(
@@ -391 +400 @@
     }
 
-    if ( is_wp_error( $raw_response ) || 200 != wp_remote_retrieve_response_code( $raw_response ) ) {
+    if ( is_wp_error( $raw_response ) || 200 !== wp_remote_retrieve_response_code( $raw_response ) ) {
         return;
     }
 
     $response = json_decode( wp_remote_retrieve_body( $raw_response ), true );
+
     foreach ( $response['plugins'] as &$plugin ) {
         $plugin = (object) $plugin;
+
         if ( isset( $plugin->compatibility ) ) {
             $plugin->compatibility = (object) $plugin->compatibility;
+
             foreach ( $plugin->compatibility as &$data ) {
                 $data = (object) $data;
@@ -405 +417 @@
         }
     }
+
     unset( $plugin, $data );
+
     foreach ( $response['no_update'] as &$plugin ) {
         $plugin = (object) $plugin;
     }
+
     unset( $plugin );
 
@@ -449 +464 @@
 
     $last_update = get_site_transient( 'update_themes' );
+
     if ( ! is_object( $last_update ) ) {
         $last_update = new stdClass;
@@ -500 +516 @@
     if ( $time_not_changed && ! $extra_stats ) {
         $theme_changed = false;
+
         foreach ( $checked as $slug => $v ) {
             if ( ! isset( $last_update->checked[ $slug ] ) || strval( $last_update->checked[ $slug ] ) !== strval( $v ) ) {
@@ -564 +581 @@
     $http_url = $url;
     $ssl      = wp_http_supports( array( 'ssl' ) );
+
     if ( $ssl ) {
         $url = set_url_scheme( $url, 'https' );
@@ -569 +587 @@
 
     $raw_response = wp_remote_post( $url, $options );
+
     if ( $ssl && is_wp_error( $raw_response ) ) {
         trigger_error(
@@ -581 +600 @@
     }
 
-    if ( is_wp_error( $raw_response ) || 200 != wp_remote_retrieve_response_code( $raw_response ) ) {
+    if ( is_wp_error( $raw_response ) || 200 !== wp_remote_retrieve_response_code( $raw_response ) ) {
         return;
     }
@@ -626 +645 @@
         'update_themes'  => 'theme',
     );
+
     foreach ( $transients as $transient => $type ) {
         $transient = get_site_transient( $transient );
+
         if ( empty( $transient->translations ) ) {
             continue;
@@ -636 +657 @@
         }
     }
+
     return $updates;
 }
@@ -655 +677 @@
 
     $plugins = current_user_can( 'update_plugins' );
+
     if ( $plugins ) {
         $update_plugins = get_site_transient( 'update_plugins' );
+
         if ( ! empty( $update_plugins->response ) ) {
             $counts['plugins'] = count( $update_plugins->response );
@@ -663 +687 @@
 
     $themes = current_user_can( 'update_themes' );
+
     if ( $themes ) {
         $update_themes = get_site_transient( 'update_themes' );
+
         if ( ! empty( $update_themes->response ) ) {
             $counts['themes'] = count( $update_themes->response );
@@ -671 +697 @@
 
     $core = current_user_can( 'update_core' );
+
     if ( $core && function_exists( 'get_core_updates' ) ) {
         $update_wordpress = get_core_updates( array( 'dismissed' => false ) );
+
         if ( ! empty( $update_wordpress )
             && ! in_array( $update_wordpress[0]->response, array( 'development', 'latest' ), true )
@@ -687 +715 @@
     $counts['total'] = $counts['plugins'] + $counts['themes'] + $counts['wordpress'] + $counts['translations'];
     $titles          = array();
+
     if ( $counts['wordpress'] ) {
         /* translators: %d: Number of available WordPress updates. */
         $titles['wordpress'] = sprintf( __( '%d WordPress Update' ), $counts['wordpress'] );
     }
+
     if ( $counts['plugins'] ) {
         /* translators: %d: Number of available plugin updates. */
         $titles['plugins'] = sprintf( _n( '%d Plugin Update', '%d Plugin Updates', $counts['plugins'] ), $counts['plugins'] );
     }
+
     if ( $counts['themes'] ) {
         /* translators: %d: Number of available theme updates. */
         $titles['themes'] = sprintf( _n( '%d Theme Update', '%d Theme Updates', $counts['themes'] ), $counts['themes'] );
     }
+
     if ( $counts['translations'] ) {
         $titles['translations'] = __( 'Translation Updates' );
@@ -738 +770 @@
     $current = get_site_transient( 'update_core' );
 
-    if ( isset( $current->last_checked, $current->version_checked ) &&
-        12 * HOUR_IN_SECONDS > ( time() - $current->last_checked ) &&
-        $current->version_checked == $wp_version ) {
-        return;
-    }
+    if ( isset( $current->last_checked, $current->version_checked )
+        && 12 * HOUR_IN_SECONDS > ( time() - $current->last_checked )
+        && $current->version_checked === $wp_version
+    ) {
+        return;
+    }
+
     wp_version_check();
 }
@@ -757 +791 @@
 function _maybe_update_plugins() {
     $current = get_site_transient( 'update_plugins' );
-    if ( isset( $current->last_checked ) && 12 * HOUR_IN_SECONDS > ( time() - $current->last_checked ) ) {
-        return;
-    }
+
+    if ( isset( $current->last_checked )
+        && 12 * HOUR_IN_SECONDS > ( time() - $current->last_checked )
+    ) {
+        return;
+    }
+
     wp_update_plugins();
 }
@@ -774 +812 @@
 function _maybe_update_themes() {
     $current = get_site_transient( 'update_themes' );
-    if ( isset( $current->last_checked ) && 12 * HOUR_IN_SECONDS > ( time() - $current->last_checked ) ) {
-        return;
-    }
+
+    if ( isset( $current->last_checked )
+        && 12 * HOUR_IN_SECONDS > ( time() - $current->last_checked )
+    ) {
+        return;
+    }
+
     wp_update_themes();
 }
@@ -810 +852 @@
         delete_site_transient( 'update_plugins' );
     }
+
     wp_clean_themes_cache();
+
     delete_site_transient( 'update_core' );
 }