Changeset 47785 for trunk/src/wp-admin/edit-form-advanced.php

Timestamp:

05/12/2020 06:30:03 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in some wp-admin files.

Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239.

File:

• trunk/src/wp-admin/edit-form-advanced.php (modified) (14 diffs)

trunk/src/wp-admin/edit-form-advanced.php

@@ -77 +77 @@
 $action  = isset( $action ) ? $action : '';
 
-if ( get_option( 'page_for_posts' ) == $post_ID && empty( $post->post_content ) ) {
+if ( (int) get_option( 'page_for_posts' ) === $post_ID && empty( $post->post_content ) ) {
     add_action( 'edit_form_after_title', '_wp_posts_page_notice' );
     remove_post_type_support( $post_type, 'editor' );
@@ -229 +229 @@
 $notice     = false;
 $form_extra = '';
-if ( 'auto-draft' == $post->post_status ) {
-    if ( 'edit' == $action ) {
+if ( 'auto-draft' === $post->post_status ) {
+    if ( 'edit' === $action ) {
         $post->post_title = '';
     }
@@ -277 +277 @@
 );
 
-if ( 'post' == $post_type ) {
+if ( 'post' === $post_type ) {
     $customize_display = '<p>' . __( 'The title field and the big Post Editing Area are fixed in place, but you can reposition all the other boxes using drag and drop. You can also minimize or expand them by clicking the title bar of each box. Use the Screen Options tab to unhide more boxes (Excerpt, Send Trackbacks, Custom Fields, Discussion, Slug, Author) or to choose a 1- or 2-column layout for this screen.' ) . '</p>';
 
@@ -314 +314 @@
             '<p>' . __( '<a href="https://wordpress.org/support/">Support</a>' ) . '</p>'
     );
-} elseif ( 'page' == $post_type ) {
+} elseif ( 'page' === $post_type ) {
     $about_pages = '<p>' . __( 'Pages are similar to posts in that they have a title, body text, and associated metadata, but they are different in that they are not part of the chronological blog stream, kind of like permanent posts. Pages are not categorized or tagged, but can have a hierarchy. You can nest pages under other pages by making one the &#8220;Parent&#8221; of the other, creating a group of pages.' ) . '</p>' .
         '<p>' . __( 'Creating a Page is very similar to creating a Post, and the screens can be customized in the same way using drag and drop, the Screen Options tab, and expanding/collapsing boxes as you choose. This screen also has the distraction-free writing space, available in both the Visual and Text modes via the Fullscreen buttons. The Page editor mostly works the same as the Post editor, but there are some Page-specific features in the Page Attributes box.' ) . '</p>';
@@ -332 +332 @@
             '<p>' . __( '<a href="https://wordpress.org/support/">Support</a>' ) . '</p>'
     );
-} elseif ( 'attachment' == $post_type ) {
+} elseif ( 'attachment' === $post_type ) {
     get_current_screen()->add_help_tab(
         array(
@@ -352 +352 @@
 }
 
-if ( 'post' == $post_type || 'page' == $post_type ) {
+if ( 'post' === $post_type || 'page' === $post_type ) {
     $inserting_media  = '<p>' . __( 'You can upload and insert media (images, audio, documents, etc.) by clicking the Add Media button. You can select from the images and files already uploaded to the Media Library, or upload new media to add to your page or post. To create an image gallery, select the images to add and click the &#8220;Create a new gallery&#8221; button.' ) . '</p>';
     $inserting_media .= '<p>' . __( 'You can also embed media from many popular websites including Twitter, YouTube, Flickr and others by pasting the media URL on its own line into the content of your post/page. <a href="https://wordpress.org/support/article/embeds/">Learn more about embeds</a>.' ) . '</p>';
@@ -365 +365 @@
 }
 
-if ( 'post' == $post_type ) {
+if ( 'post' === $post_type ) {
     $publish_box  = '<p>' . __( 'Several boxes on this screen contain settings for how your content will be published, including:' ) . '</p>';
     $publish_box .= '<ul><li>' .
@@ -403 +403 @@
         )
     );
-} elseif ( 'page' == $post_type ) {
+} elseif ( 'page' === $post_type ) {
     $page_attributes = '<p>' . __( '<strong>Parent</strong> &mdash; You can arrange your pages in hierarchies. For example, you could have an &#8220;About&#8221; page that has &#8220;Life Story&#8221; and &#8220;My Dog&#8221; pages under it. There are no limits to how many levels you can nest pages.' ) . '</p>' .
         '<p>' . __( '<strong>Template</strong> &mdash; Some themes have custom templates you can use for certain pages that might have additional features or custom layouts. If so, you&#8217;ll see them in this dropdown menu.' ) . '</p>' .
@@ -472 +472 @@
     <?php
 }
-if ( 'draft' != get_post_status( $post ) ) {
+if ( 'draft' !== get_post_status( $post ) ) {
     wp_original_referer_field( true, 'previous' );
 }
@@ -496 +496 @@
 
 <div id="poststuff">
-<div id="post-body" class="metabox-holder columns-<?php echo 1 == get_current_screen()->get_columns() ? '1' : '2'; ?>">
+<div id="post-body" class="metabox-holder columns-<?php echo ( 1 === get_current_screen()->get_columns() ) ? '1' : '2'; ?>">
 <div id="post-body-content">
 
@@ -536 +536 @@
 
             if ( ! empty( $shortlink ) && $shortlink !== $permalink && home_url( '?page_id=' . $post->ID ) !== $permalink ) {
-                $sample_permalink_html .= '<input id="shortlink" type="hidden" value="' . esc_attr( $shortlink ) . '" /><button type="button" class="button button-small" onclick="prompt(&#39;URL:&#39;, jQuery(\'#shortlink\').val());">' . __( 'Get Shortlink' ) . '</button>';
+                $sample_permalink_html .= '<input id="shortlink" type="hidden" value="' . esc_attr( $shortlink ) . '" />' .
+                    '<button type="button" class="button button-small" onclick="prompt(&#39;URL:&#39;, jQuery(\'#shortlink\').val());">' .
+                    __( 'Get Shortlink' ) .
+                    '</button>';
             }
         }
 
-        if ( $post_type_object->public && ! ( 'pending' == get_post_status( $post ) && ! current_user_can( $post_type_object->cap->publish_posts ) ) ) {
-            $has_sample_permalink = $sample_permalink_html && 'auto-draft' != $post->post_status;
+        if ( $post_type_object->public
+            && ! ( 'pending' === get_post_status( $post ) && ! current_user_can( $post_type_object->cap->publish_posts ) )
+        ) {
+            $has_sample_permalink = $sample_permalink_html && 'auto-draft' !== $post->post_status;
             ?>
     <div id="edit-slug-box" class="hide-if-no-js">
@@ -609 +614 @@
     <span class="autosave-message">&nbsp;</span>
     <?php
-    if ( 'auto-draft' != $post->post_status ) {
+    if ( 'auto-draft' !== $post->post_status ) {
         echo '<span id="last-edit">';
         $last_user = get_userdata( get_post_meta( $post_ID, '_edit_last', true ) );
@@ -643 +648 @@
 <?php
 
-if ( 'page' == $post_type ) {
+if ( 'page' === $post_type ) {
     /**
      * Fires before meta boxes with 'side' context are output for the 'page' post type.
@@ -677 +682 @@
 do_meta_boxes( null, 'normal', $post );
 
-if ( 'page' == $post_type ) {
+if ( 'page' === $post_type ) {
     /**
      * Fires after 'normal' context meta boxes have been output for the 'page' post type.