Changeset 47785 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

05/12/2020 06:30:03 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in some wp-admin files.

Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (6 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -2347 +2347 @@
         $query = $wpdb->prepare( 'SHOW TABLES LIKE %s', $wpdb->esc_like( $table_name ) );
 
-        if ( $wpdb->get_var( $query ) == $table_name ) {
+        if ( $wpdb->get_var( $query ) === $table_name ) {
                 return true;
         }
@@ -2355 +2355 @@
 
         // We cannot directly tell that whether this succeeded!
-        if ( $wpdb->get_var( $query ) == $table_name ) {
+        if ( $wpdb->get_var( $query ) === $table_name ) {
                 return true;
         }
+
         return false;
 }
@@ -2374 +2375 @@
 function drop_index( $table, $index ) {
         global $wpdb;
+
         $wpdb->hide_errors();
+
         $wpdb->query( "ALTER TABLE `$table` DROP INDEX `$index`" );
+
         // Now we need to take out all the extra ones we may have created.
         for ( $i = 0; $i < 25; $i++ ) {
                 $wpdb->query( "ALTER TABLE `$table` DROP INDEX `{$index}_$i`" );
         }
+
         $wpdb->show_errors();
+
         return true;
 }
@@ -2397 +2403 @@
 function add_clean_index( $table, $index ) {
         global $wpdb;
+
         drop_index( $table, $index );
         $wpdb->query( "ALTER TABLE `$table` ADD INDEX ( `$index` )" );
+
         return true;
 }
@@ -2416 +2424 @@
 function maybe_add_column( $table_name, $column_name, $create_ddl ) {
         global $wpdb;
+
         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
-                if ( $column == $column_name ) {
+                if ( $column === $column_name ) {
                         return true;
                 }
@@ -2427 +2436 @@
         // We cannot directly tell that whether this succeeded!
         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
-                if ( $column == $column_name ) {
+                if ( $column === $column_name ) {
                         return true;
                 }
         }
+
         return false;
 }