Changeset 47808 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (24 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -177 +177 @@
     }
 
-    if ( ini_get( 'zlib.output_compression' ) || 'ob_gzhandler' == ini_get( 'output_handler' ) ) {
+    if ( ini_get( 'zlib.output_compression' ) || 'ob_gzhandler' === ini_get( 'output_handler' ) ) {
         update_site_option( 'can_compress_scripts', 0 );
         wp_die( 0 );
@@ -210 +210 @@
             echo $out;
             wp_die();
-        } elseif ( 'no' == $_GET['test'] ) {
+        } elseif ( 'no' === $_GET['test'] ) {
             check_ajax_referer( 'update_can_compress_scripts' );
             update_site_option( 'can_compress_scripts', 0 );
-        } elseif ( 'yes' == $_GET['test'] ) {
+        } elseif ( 'yes' === $_GET['test'] ) {
             check_ajax_referer( 'update_can_compress_scripts' );
             update_site_option( 'can_compress_scripts', 1 );
@@ -705 +705 @@
 
     if ( isset( $_POST['trash'] ) && 1 == $_POST['trash'] ) {
-        if ( 'trash' == $status ) {
+        if ( 'trash' === $status ) {
             wp_die( time() );
         }
@@ -711 +711 @@
         $r = wp_trash_comment( $comment );
     } elseif ( isset( $_POST['untrash'] ) && 1 == $_POST['untrash'] ) {
-        if ( 'trash' != $status ) {
+        if ( 'trash' !== $status ) {
             wp_die( time() );
         }
@@ -722 +722 @@
         }
     } elseif ( isset( $_POST['spam'] ) && 1 == $_POST['spam'] ) {
-        if ( 'spam' == $status ) {
+        if ( 'spam' === $status ) {
             wp_die( time() );
         }
@@ -728 +728 @@
         $r = wp_spam_comment( $comment );
     } elseif ( isset( $_POST['unspam'] ) && 1 == $_POST['unspam'] ) {
-        if ( 'spam' != $status ) {
+        if ( 'spam' !== $status ) {
             wp_die( time() );
         }
@@ -884 +884 @@
     }
 
-    if ( 'trash-post' == $action ) {
+    if ( 'trash-post' === $action ) {
         $done = wp_trash_post( $id );
     } else {
@@ -1302 +1302 @@
     }
 
-    if ( '' == $comment_content ) {
+    if ( '' === $comment_content ) {
         wp_die( __( 'Error: Please type a comment.' ) );
     }
@@ -1345 +1345 @@
 
     ob_start();
-    if ( isset( $_REQUEST['mode'] ) && 'dashboard' == $_REQUEST['mode'] ) {
+    if ( isset( $_REQUEST['mode'] ) && 'dashboard' === $_REQUEST['mode'] ) {
         require_once ABSPATH . 'wp-admin/includes/dashboard.php';
         _wp_dashboard_recent_comments_row( $comment );
     } else {
-        if ( isset( $_REQUEST['mode'] ) && 'single' == $_REQUEST['mode'] ) {
+        if ( isset( $_REQUEST['mode'] ) && 'single' === $_REQUEST['mode'] ) {
             $wp_list_table = _get_list_table( 'WP_Post_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
         } else {
@@ -1404 +1404 @@
     }
 
-    if ( '' == $_POST['content'] ) {
+    if ( '' === $_POST['content'] ) {
         wp_die( __( 'Error: Please type a comment.' ) );
     }
@@ -1462 +1462 @@
         if (
             ! empty( $menu_item_data['menu-item-type'] ) &&
-            'custom' != $menu_item_data['menu-item-type'] &&
+            'custom' !== $menu_item_data['menu-item-type'] &&
             ! empty( $menu_item_data['menu-item-object-id'] )
         ) {
@@ -1545 +1545 @@
         }
 
-        if ( isset( $_POST['metakeyselect'] ) && '#NONE#' == $_POST['metakeyselect'] && empty( $_POST['metakeyinput'] ) ) {
+        if ( isset( $_POST['metakeyselect'] ) && '#NONE#' === $_POST['metakeyselect'] && empty( $_POST['metakeyinput'] ) ) {
             wp_die( 1 );
         }
@@ -1605 +1605 @@
         $value = wp_unslash( $_POST['meta'][ $mid ]['value'] );
 
-        if ( '' == trim( $key ) ) {
+        if ( '' === trim( $key ) ) {
             wp_die( __( 'Please provide a custom field name.' ) );
         }
@@ -1796 +1796 @@
     require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
 
-    if ( isset( $_POST['item-type'] ) && 'post_type' == $_POST['item-type'] ) {
+    if ( isset( $_POST['item-type'] ) && 'post_type' === $_POST['item-type'] ) {
         $type     = 'posttype';
         $callback = 'wp_nav_menu_item_post_type_meta_box';
         $items    = (array) get_post_types( array( 'show_in_nav_menus' => true ), 'object' );
-    } elseif ( isset( $_POST['item-type'] ) && 'taxonomy' == $_POST['item-type'] ) {
+    } elseif ( isset( $_POST['item-type'] ) && 'taxonomy' === $_POST['item-type'] ) {
         $type     = 'taxonomy';
         $callback = 'wp_nav_menu_item_taxonomy_meta_box';
@@ -1986 +1986 @@
     $post_ID = (int) $_POST['post_ID'];
 
-    if ( 'page' == $_POST['post_type'] ) {
+    if ( 'page' === $_POST['post_type'] ) {
         if ( ! current_user_can( 'edit_page', $post_ID ) ) {
             wp_die( __( 'Sorry, you are not allowed to edit this page.' ) );
@@ -2031 +2031 @@
 
     // Status.
-    if ( isset( $data['keep_private'] ) && 'private' == $data['keep_private'] ) {
+    if ( isset( $data['keep_private'] ) && 'private' === $data['keep_private'] ) {
         $data['visibility']  = 'private';
         $data['post_status'] = 'private';
@@ -2181 +2181 @@
     foreach ( $posts as $post ) {
         $title = trim( $post->post_title ) ? $post->post_title : __( '(no title)' );
-        $alt   = ( 'alternate' == $alt ) ? '' : 'alternate';
+        $alt   = ( 'alternate' === $alt ) ? '' : 'alternate';
 
         switch ( $post->post_status ) {
@@ -2199 +2199 @@
         }
 
-        if ( '0000-00-00 00:00:00' == $post->post_date ) {
+        if ( '0000-00-00 00:00:00' === $post->post_date ) {
             $time = '';
         } else {
@@ -2884 +2884 @@
     }
 
-    if ( 'attachment' != $post->post_type ) {
+    if ( 'attachment' !== $post->post_type ) {
         wp_send_json_error();
     }
@@ -2997 +2997 @@
     $post    = get_post( $id, ARRAY_A );
 
-    if ( 'attachment' != $post['post_type'] ) {
+    if ( 'attachment' !== $post['post_type'] ) {
         wp_send_json_error();
     }
@@ -3088 +3088 @@
     $post = get_post( $id, ARRAY_A );
 
-    if ( 'attachment' != $post['post_type'] ) {
+    if ( 'attachment' !== $post['post_type'] ) {
         wp_send_json_error();
     }
@@ -3155 +3155 @@
         }
 
-        if ( 'attachment' != $attachment->post_type ) {
+        if ( 'attachment' !== $attachment->post_type ) {
             continue;
         }
@@ -3191 +3191 @@
     }
 
-    if ( 'attachment' != $post->post_type ) {
+    if ( 'attachment' !== $post->post_type ) {
         wp_send_json_error();
     }
@@ -3305 +3305 @@
     if ( $ext ) {
         $ext_type = wp_ext2type( $ext );
-        if ( 'audio' == $ext_type || 'video' == $ext_type ) {
+        if ( 'audio' === $ext_type || 'video' === $ext_type ) {
             $type = $ext_type;
         }