Changeset 47808 for trunk/src/wp-admin/includes/bookmark.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/bookmark.php (modified) (4 diffs)

trunk/src/wp-admin/includes/bookmark.php

@@ -40 +40 @@
     $_POST['link_image'] = esc_html( $_POST['link_image'] );
     $_POST['link_rss']   = esc_url( $_POST['link_rss'] );
-    if ( ! isset( $_POST['link_visible'] ) || 'N' != $_POST['link_visible'] ) {
+    if ( ! isset( $_POST['link_visible'] ) || 'N' !== $_POST['link_visible'] ) {
         $_POST['link_visible'] = 'Y';
     }
@@ -175 +175 @@
     }
 
-    if ( trim( $link_name ) == '' ) {
-        if ( trim( $link_url ) != '' ) {
+    if ( '' === trim( $link_name ) ) {
+        if ( '' !== trim( $link_url ) ) {
             $link_name = $link_url;
         } else {
@@ -183 +183 @@
     }
 
-    if ( trim( $link_url ) == '' ) {
+    if ( '' === trim( $link_url ) ) {
         return 0;
     }
@@ -310 +310 @@
 function wp_link_manager_disabled_message() {
     global $pagenow;
-    if ( 'link-manager.php' != $pagenow && 'link-add.php' != $pagenow && 'link.php' != $pagenow ) {
+
+    if ( ! in_array( $pagenow, array( 'link-manager.php', 'link-add.php', 'link.php' ), true ) ) {
         return;
     }