Changeset 47808 for trunk/src/wp-admin/includes/class-wp-upgrader.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -332 +332 @@
         if ( is_wp_error( $result ) ) {
             $wp_filesystem->delete( $working_dir, true );
-            if ( 'incompatible_archive' == $result->get_error_code() ) {
+            if ( 'incompatible_archive' === $result->get_error_code() ) {
                 return new WP_Error( 'incompatible_archive', $this->strings['incompatible_archive'], $result->get_error_data() );
             }
@@ -399 +399 @@
             if ( ! $wp_filesystem->is_writable( $remote_destination . $filename ) ) {
                 // Attempt to alter permissions to allow writes and try again.
-                $wp_filesystem->chmod( $remote_destination . $filename, ( 'd' == $file_details['type'] ? FS_CHMOD_DIR : FS_CHMOD_FILE ) );
+                $wp_filesystem->chmod( $remote_destination . $filename, ( 'd' === $file_details['type'] ? FS_CHMOD_DIR : FS_CHMOD_FILE ) );
                 if ( ! $wp_filesystem->is_writable( $remote_destination . $filename ) ) {
                     $unwritable_files[] = $filename;
@@ -604 +604 @@
 
         $destination_name = basename( str_replace( $local_destination, '', $destination ) );
-        if ( '.' == $destination_name ) {
+        if ( '.' === $destination_name ) {
             $destination_name = '';
         }
@@ -745 +745 @@
 
             // Don't output the 'no signature could be found' failure message for now.
-            if ( 'signature_verification_no_signature' != $download->get_error_code() || WP_DEBUG ) {
+            if ( 'signature_verification_no_signature' !== $download->get_error_code() || WP_DEBUG ) {
                 // Output the failure error as a normal feedback, and not as an error.
                 $this->skin->feedback( $download->get_error_message() );