Changeset 47808 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

05/16/2020 06:40:52 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (7 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -138 +138 @@
     }
 
-    if ( 'POST' == $_SERVER['REQUEST_METHOD'] && isset( $_POST['widget_id'] ) ) {
+    if ( 'POST' === $_SERVER['REQUEST_METHOD'] && isset( $_POST['widget_id'] ) ) {
         check_admin_referer( 'edit-dashboard-widget_' . $_POST['widget_id'], 'dashboard-widget-nonce' );
         ob_start(); // Hack - but the same hack wp-admin/widgets.php uses.
@@ -283 +283 @@
         $num_posts = wp_count_posts( $post_type );
         if ( $num_posts && $num_posts->publish ) {
-            if ( 'post' == $post_type ) {
+            if ( 'post' === $post_type ) {
                 /* translators: %s: Number of posts. */
                 $text = _n( '%s Post', '%s Posts', $num_posts->publish );
@@ -759 +759 @@
         foreach ( $actions as $action => $link ) {
             ++$i;
-            ( ( ( 'approve' == $action || 'unapprove' == $action ) && 2 === $i ) || 1 === $i ) ? $sep = '' : $sep = ' | ';
+
+            if ( ( ( 'approve' === $action || 'unapprove' === $action ) && 2 === $i ) || 1 === $i ) {
+                $sep = '';
+            } else {
+                $sep = ' | ';
+            }
 
             // Reply and quickedit need a hide-if-no-js span.
-            if ( 'reply' == $action || 'quickedit' == $action ) {
+            if ( 'reply' === $action || 'quickedit' === $action ) {
                 $action .= ' hide-if-no-js';
             }
@@ -769 +774 @@
                 $action .= ' hidden';
             }
+
             $actions_string .= "<span class='$action'>$sep$link</span>";
         }
@@ -785 +791 @@
             ?>
 
-            <?php if ( ! $comment->comment_type || 'comment' == $comment->comment_type ) : ?>
+            <?php if ( ! $comment->comment_type || 'comment' === $comment->comment_type ) : ?>
 
             <div class="dashboard-comment-wrap has-row-actions <?php echo $comment_row_class; ?>">
@@ -1175 +1181 @@
     $widget_options[ $widget_id ]['number'] = $number;
 
-    if ( 'POST' == $_SERVER['REQUEST_METHOD'] && isset( $_POST['widget-rss'][ $number ] ) ) {
+    if ( 'POST' === $_SERVER['REQUEST_METHOD'] && isset( $_POST['widget-rss'][ $number ] ) ) {
         $_POST['widget-rss'][ $number ]         = wp_unslash( $_POST['widget-rss'][ $number ] );
         $widget_options[ $widget_id ]           = wp_widget_rss_process( $_POST['widget-rss'][ $number ] );
@@ -1892 +1898 @@
         <h3><?php _e( 'Next Steps' ); ?></h3>
         <ul>
-        <?php if ( 'page' == get_option( 'show_on_front' ) && ! get_option( 'page_for_posts' ) ) : ?>
+        <?php if ( 'page' === get_option( 'show_on_front' ) && ! get_option( 'page_for_posts' ) ) : ?>
             <li><?php printf( '<a href="%s" class="welcome-icon welcome-edit-page">' . __( 'Edit your front page' ) . '</a>', get_edit_post_link( get_option( 'page_on_front' ) ) ); ?></li>
             <li><?php printf( '<a href="%s" class="welcome-icon welcome-add-page">' . __( 'Add additional pages' ) . '</a>', admin_url( 'post-new.php?post_type=page' ) ); ?></li>
-        <?php elseif ( 'page' == get_option( 'show_on_front' ) ) : ?>
+        <?php elseif ( 'page' === get_option( 'show_on_front' ) ) : ?>
             <li><?php printf( '<a href="%s" class="welcome-icon welcome-edit-page">' . __( 'Edit your front page' ) . '</a>', get_edit_post_link( get_option( 'page_on_front' ) ) ); ?></li>
             <li><?php printf( '<a href="%s" class="welcome-icon welcome-add-page">' . __( 'Add additional pages' ) . '</a>', admin_url( 'post-new.php?post_type=page' ) ); ?></li>