Changeset 47808 for trunk/src/wp-admin/includes/export.php

Timestamp:

05/16/2020 06:40:52 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/export.php (modified) (7 diffs)

trunk/src/wp-admin/includes/export.php

@@ -97 +97 @@
     header( 'Content-Type: text/xml; charset=' . get_option( 'blog_charset' ), true );
 
-    if ( 'all' != $args['content'] && post_type_exists( $args['content'] ) ) {
+    if ( 'all' !== $args['content'] && post_type_exists( $args['content'] ) ) {
         $ptype = get_post_type_object( $args['content'] );
         if ( ! $ptype->can_export ) {
@@ -112 +112 @@
     }
 
-    if ( $args['status'] && ( 'post' == $args['content'] || 'page' == $args['content'] ) ) {
+    if ( $args['status'] && ( 'post' === $args['content'] || 'page' === $args['content'] ) ) {
         $where .= $wpdb->prepare( " AND {$wpdb->posts}.post_status = %s", $args['status'] );
     } else {
@@ -119 +119 @@
 
     $join = '';
-    if ( $args['category'] && 'post' == $args['content'] ) {
+    if ( $args['category'] && 'post' === $args['content'] ) {
         $term = term_exists( $args['category'], 'category' );
         if ( $term ) {
@@ -127 +127 @@
     }
 
-    if ( 'post' == $args['content'] || 'page' == $args['content'] || 'attachment' == $args['content'] ) {
+    if ( in_array( $args['content'], array( 'post', 'page', 'attachment' ), true ) ) {
         if ( $args['author'] ) {
             $where .= $wpdb->prepare( " AND {$wpdb->posts}.post_author = %d", $args['author'] );
@@ -155 +155 @@
         $cats = array( $cat->term_id => $cat );
         unset( $term, $cat );
-    } elseif ( 'all' == $args['content'] ) {
+    } elseif ( 'all' === $args['content'] ) {
         $categories = (array) get_categories( array( 'get' => 'all' ) );
         $tags       = (array) get_tags( array( 'get' => 'all' ) );
@@ -429 +429 @@
      */
     function wxr_filter_postmeta( $return_me, $meta_key ) {
-        if ( '_edit_lock' == $meta_key ) {
+        if ( '_edit_lock' === $meta_key ) {
             $return_me = true;
         }
@@ -514 +514 @@
     <?php endforeach; ?>
     <?php
-    if ( 'all' == $args['content'] ) {
+    if ( 'all' === $args['content'] ) {
         wxr_nav_menu_terms();}
     ?>