Changeset 47808 for trunk/src/wp-admin/includes/image-edit.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/image-edit.php (modified) (5 diffs)

trunk/src/wp-admin/includes/image-edit.php

@@ -777 +777 @@
     $fheight = ! empty( $_REQUEST['fheight'] ) ? intval( $_REQUEST['fheight'] ) : 0;
     $target  = ! empty( $_REQUEST['target'] ) ? preg_replace( '/[^a-z0-9_-]+/i', '', $_REQUEST['target'] ) : '';
-    $scale   = ! empty( $_REQUEST['do'] ) && 'scale' == $_REQUEST['do'];
+    $scale   = ! empty( $_REQUEST['do'] ) && 'scale' === $_REQUEST['do'];
 
     if ( $scale && $fwidth > 0 && $fheight > 0 ) {
@@ -831 +831 @@
         isset( $backup_sizes['full-orig'] ) && $backup_sizes['full-orig']['file'] != $basename ) {
 
-        if ( 'thumbnail' == $target ) {
+        if ( 'thumbnail' === $target ) {
             $new_path = "{$dirname}/{$filename}-temp.{$ext}";
         } else {
@@ -881 +881 @@
         $meta['height'] = $size['height'];
 
-        if ( $success && ( 'nothumb' == $target || 'all' == $target ) ) {
+        if ( $success && ( 'nothumb' === $target || 'all' === $target ) ) {
             $sizes = get_intermediate_image_sizes();
-            if ( 'nothumb' == $target ) {
+            if ( 'nothumb' === $target ) {
                 $sizes = array_diff( $sizes, array( 'thumbnail' ) );
             }
@@ -890 +890 @@
         $return->fw = $meta['width'];
         $return->fh = $meta['height'];
-    } elseif ( 'thumbnail' == $target ) {
+    } elseif ( 'thumbnail' === $target ) {
         $sizes   = array( 'thumbnail' );
         $success = true;
@@ -959 +959 @@
         if ( 'thumbnail' === $target || 'all' === $target || 'full' === $target ) {
             // Check if it's an image edit from attachment edit screen.
-            if ( ! empty( $_REQUEST['context'] ) && 'edit-attachment' == $_REQUEST['context'] ) {
+            if ( ! empty( $_REQUEST['context'] ) && 'edit-attachment' === $_REQUEST['context'] ) {
                 $thumb_url         = wp_get_attachment_image_src( $post_id, array( 900, 600 ), true );
                 $return->thumbnail = $thumb_url[0];