Changeset 47808 for trunk/src/wp-admin/includes/media.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/media.php (modified) (14 diffs)

trunk/src/wp-admin/includes/media.php

@@ -681 +681 @@
     $upload_iframe_src = add_query_arg( 'post_id', (int) $post_id, admin_url( 'media-upload.php' ) );
 
-    if ( $type && 'media' != $type ) {
+    if ( $type && 'media' !== $type ) {
         $upload_iframe_src = add_query_arg( 'type', $type, $upload_iframe_src );
     }
@@ -866 +866 @@
         }
 
-        if ( isset( $_POST['media_type'] ) && 'image' != $_POST['media_type'] ) {
+        if ( isset( $_POST['media_type'] ) && 'image' !== $_POST['media_type'] ) {
             $title = esc_html( wp_unslash( $_POST['title'] ) );
             if ( empty( $title ) ) {
@@ -881 +881 @@
             if ( $ext ) {
                 $ext_type = wp_ext2type( $ext );
-                if ( 'audio' == $ext_type || 'video' == $ext_type ) {
+                if ( 'audio' === $ext_type || 'video' === $ext_type ) {
                     $type = $ext_type;
                 }
@@ -1160 +1160 @@
 
         // Is this size selectable?
-        $enabled = ( $downsize[3] || 'full' == $size );
+        $enabled = ( $downsize[3] || 'full' === $size );
         $css_id  = "image-size-{$size}-{$post->ID}";
 
@@ -1170 +1170 @@
                 $check = '';
             }
-        } elseif ( ! $check && $enabled && 'thumbnail' != $size ) {
+        } elseif ( ! $check && $enabled && 'thumbnail' !== $size ) {
             /*
              * If $check is not enabled, default to the first available size
@@ -1303 +1303 @@
  */
 function image_attachment_fields_to_save( $post, $attachment ) {
-    if ( substr( $post['post_mime_type'], 0, 5 ) == 'image' ) {
+    if ( 'image' === substr( $post['post_mime_type'], 0, 5 ) ) {
         if ( strlen( trim( $post['post_title'] ) ) == 0 ) {
             $attachment_url                           = ( isset( $post['attachment_url'] ) ) ? $post['attachment_url'] : $post['guid'];
@@ -1327 +1327 @@
     $post = get_post( $attachment_id );
 
-    if ( substr( $post->post_mime_type, 0, 5 ) == 'image' ) {
+    if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) {
         $url   = $attachment['url'];
         $align = ! empty( $attachment['align'] ) ? $attachment['align'] : 'none';
@@ -1438 +1438 @@
 
     // This was formerly in image_attachment_fields_to_edit().
-    if ( substr( $post->post_mime_type, 0, 5 ) == 'image' ) {
+    if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) {
         $alt = get_post_meta( $post->ID, '_wp_attachment_image_alt', true );
 
@@ -1611 +1611 @@
     $display_title = $parsed_args['show_title'] ? "<div class='filename new'><span class='title'>" . wp_html_excerpt( $display_title, 60, '&hellip;' ) . '</span></div>' : '';
 
-    $gallery = ( ( isset( $_REQUEST['tab'] ) && 'gallery' == $_REQUEST['tab'] ) || ( isset( $redir_tab ) && 'gallery' == $redir_tab ) );
+    $gallery = ( ( isset( $_REQUEST['tab'] ) && 'gallery' === $_REQUEST['tab'] ) || ( isset( $redir_tab ) && 'gallery' === $redir_tab ) );
     $order   = '';
 
     foreach ( $form_fields as $key => $val ) {
-        if ( 'menu_order' == $key ) {
+        if ( 'menu_order' === $key ) {
             if ( $gallery ) {
                 $order = "<div class='menu_order'> <input class='menu_order_input' type='text' id='attachments[$attachment_id][menu_order]' name='attachments[$attachment_id][menu_order]' value='" . esc_attr( $val['value'] ) . "' /></div>";
@@ -1726 +1726 @@
     }
 
-    if ( 'image' == $type && $calling_post_id && current_theme_supports( 'post-thumbnails', get_post_type( $calling_post_id ) )
-        && post_type_supports( get_post_type( $calling_post_id ), 'thumbnail' ) && get_post_thumbnail_id( $calling_post_id ) != $attachment_id ) {
+    if ( 'image' === $type && $calling_post_id
+        && current_theme_supports( 'post-thumbnails', get_post_type( $calling_post_id ) )
+        && post_type_supports( get_post_type( $calling_post_id ), 'thumbnail' )
+        && get_post_thumbnail_id( $calling_post_id ) != $attachment_id
+    ) {
 
         $calling_post             = get_post( $calling_post_id );
@@ -1770 +1773 @@
             $item .= $field[ $field['input'] ];
         } elseif ( 'textarea' === $field['input'] ) {
-            if ( 'post_content' == $id && user_can_richedit() ) {
+            if ( 'post_content' === $id && user_can_richedit() ) {
                 // Sanitize_post() skips the post_content when user_can_richedit.
                 $field['value'] = htmlspecialchars( $field['value'], ENT_QUOTES );
@@ -1963 +1966 @@
             $item .= $field[ $field['input'] ];
         } elseif ( 'textarea' === $field['input'] ) {
-            if ( 'post_content' == $id && user_can_richedit() ) {
+            if ( 'post_content' === $id && user_can_richedit() ) {
                 // sanitize_post() skips the post_content when user_can_richedit.
                 $field['value'] = htmlspecialchars( $field['value'], ENT_QUOTES );
@@ -2384 +2387 @@
         var t = this, html, f = document.forms[0], cls, title = '', alt = '', caption = '';
 
-        if ( '' == f.src.value || '' == t.width )
+        if ( '' === f.src.value || '' === t.width )
             return false;
 
@@ -2891 +2894 @@
     }
 
-    if ( 'image' == $default_view ) {
+    if ( 'image' === $default_view ) {
         $view        = 'image-only';
         $table_class = '';