Changeset 47808 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (9 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -92 +92 @@
                 $plugin_data['Network'] = $plugin_data['_sitewide'];
         }
-        $plugin_data['Network'] = ( 'true' == strtolower( $plugin_data['Network'] ) );
+        $plugin_data['Network'] = ( 'true' === strtolower( $plugin_data['Network'] ) );
         unset( $plugin_data['_sitewide'] );
 
@@ -157 +157 @@
                                 }
                         }
-                } elseif ( 'hello.php' == basename( $plugin_file ) ) {
+                } elseif ( 'hello.php' === basename( $plugin_file ) ) {
                         $textdomain = 'default';
                 }
@@ -296 +296 @@
         $plugins_dir  = @ opendir( $plugin_root );
         $plugin_files = array();
+
         if ( $plugins_dir ) {
                 while ( ( $file = readdir( $plugins_dir ) ) !== false ) {
-                        if ( substr( $file, 0, 1 ) == '.' ) {
+                        if ( '.' === substr( $file, 0, 1 ) ) {
                                 continue;
                         }
+
                         if ( is_dir( $plugin_root . '/' . $file ) ) {
                                 $plugins_subdir = @ opendir( $plugin_root . '/' . $file );
+
                                 if ( $plugins_subdir ) {
                                         while ( ( $subfile = readdir( $plugins_subdir ) ) !== false ) {
-                                                if ( substr( $subfile, 0, 1 ) == '.' ) {
+                                                if ( '.' === substr( $subfile, 0, 1 ) ) {
                                                         continue;
                                                 }
-                                                if ( substr( $subfile, -4 ) == '.php' ) {
+
+                                                if ( '.php' === substr( $subfile, -4 ) ) {
                                                         $plugin_files[] = "$file/$subfile";
                                                 }
                                         }
+
                                         closedir( $plugins_subdir );
                                 }
                         } else {
-                                if ( substr( $file, -4 ) == '.php' ) {
+                                if ( '.php' === substr( $file, -4 ) ) {
                                         $plugin_files[] = $file;
                                 }
                         }
                 }
+
                 closedir( $plugins_dir );
         }
@@ -370 +376 @@
         if ( $plugins_dir ) {
                 while ( ( $file = readdir( $plugins_dir ) ) !== false ) {
-                        if ( substr( $file, -4 ) == '.php' ) {
+                        if ( '.php' === substr( $file, -4 ) ) {
                                 $plugin_files[] = $file;
                         }
@@ -1445 +1451 @@
          * See wp-admin/admin.php for redirect from edit.php to tools.php.
          */
-        if ( 'tools.php' == $parent_slug ) {
+        if ( 'tools.php' === $parent_slug ) {
                 $_registered_pages[ get_plugin_page_hookname( $menu_slug, 'edit.php' ) ] = true;
         }
@@ -1837 +1843 @@
                 $plugin_page, $_wp_real_parent_file, $_wp_menu_nopriv, $_wp_submenu_nopriv;
 
-        if ( ! empty( $parent ) && 'admin.php' != $parent ) {
+        if ( ! empty( $parent ) && 'admin.php' !== $parent ) {
                 if ( isset( $_wp_real_parent_file[ $parent ] ) ) {
                         $parent = $_wp_real_parent_file[ $parent ];
@@ -2019 +2025 @@
 
         $page_type = 'admin';
-        if ( empty( $parent_page ) || 'admin.php' == $parent_page || isset( $admin_page_hooks[ $plugin_page ] ) ) {
+        if ( empty( $parent_page ) || 'admin.php' === $parent_page || isset( $admin_page_hooks[ $plugin_page ] ) ) {
                 if ( isset( $admin_page_hooks[ $plugin_page ] ) ) {
                         $page_type = 'toplevel';
@@ -2166 +2172 @@
  */
 function add_option_whitelist( $new_options, $options = '' ) {
-        if ( '' == $options ) {
+        if ( '' === $options ) {
                 global $whitelist_options;
         } else {
@@ -2201 +2207 @@
  */
 function remove_option_whitelist( $del_options, $options = '' ) {
-        if ( '' == $options ) {
+        if ( '' === $options ) {
                 global $whitelist_options;
         } else {