Changeset 47808 for trunk/src/wp-admin/includes/update-core.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/update-core.php (modified) (8 diffs)

trunk/src/wp-admin/includes/update-core.php

@@ -1042 +1042 @@
         if ( is_array( $checksums ) ) {
             foreach ( $checksums as $file => $checksum ) {
-                if ( 'wp-content' == substr( $file, 0, 10 ) ) {
+                if ( 'wp-content' === substr( $file, 0, 10 ) ) {
                     continue;
                 }
@@ -1115 +1115 @@
     if ( isset( $checksums ) && is_array( $checksums ) ) {
         foreach ( $checksums as $file => $checksum ) {
-            if ( 'wp-content' == substr( $file, 0, 10 ) ) {
+            if ( 'wp-content' === substr( $file, 0, 10 ) ) {
                 continue;
             }
@@ -1188 +1188 @@
 
     // 3.5 -> 3.5+ - an empty twentytwelve directory was created upon upgrade to 3.5 for some users, preventing installation of Twenty Twelve.
-    if ( '3.5' == $old_wp_version ) {
+    if ( '3.5' === $old_wp_version ) {
         if ( is_dir( WP_CONTENT_DIR . '/themes/twentytwelve' ) && ! file_exists( WP_CONTENT_DIR . '/themes/twentytwelve/style.css' ) ) {
             $wp_filesystem->delete( $wp_filesystem->wp_themes_dir() . 'twentytwelve/' );
@@ -1204 +1204 @@
             // If a $development_build or if $introduced version is greater than what the site was previously running.
             if ( $development_build || version_compare( $introduced_version, $old_wp_version, '>' ) ) {
-                $directory             = ( '/' == $file[ strlen( $file ) - 1 ] );
-                list($type, $filename) = explode( '/', $file, 2 );
+                $directory = ( '/' === $file[ strlen( $file ) - 1 ] );
+
+                list( $type, $filename ) = explode( '/', $file, 2 );
 
                 // Check to see if the bundled items exist before attempting to copy them.
@@ -1212 +1213 @@
                 }
 
-                if ( 'plugins' == $type ) {
+                if ( 'plugins' === $type ) {
                     $dest = $wp_filesystem->wp_plugins_dir();
-                } elseif ( 'themes' == $type ) {
+                } elseif ( 'themes' === $type ) {
                     // Back-compat, ::wp_themes_dir() did not return trailingslash'd pre-3.2.
                     $dest = trailingslashit( $wp_filesystem->wp_themes_dir() );
@@ -1344 +1345 @@
         }
 
-        if ( 'f' == $fileinfo['type'] ) {
+        if ( 'f' === $fileinfo['type'] ) {
             if ( ! $wp_filesystem->copy( $from . $filename, $to . $filename, true, FS_CHMOD_FILE ) ) {
                 // If copy failed, chmod file to 0644 and try again.
@@ -1352 +1353 @@
                 }
             }
-        } elseif ( 'd' == $fileinfo['type'] ) {
+        } elseif ( 'd' === $fileinfo['type'] ) {
             if ( ! $wp_filesystem->is_dir( $to . $filename ) ) {
                 if ( ! $wp_filesystem->mkdir( $to . $filename, FS_CHMOD_DIR ) ) {
@@ -1400 +1401 @@
 
     // Ensure we only run this on the update-core.php page. The Core_Upgrader may be used in other contexts.
-    if ( 'update-core.php' != $pagenow ) {
+    if ( 'update-core.php' !== $pagenow ) {
         return;
     }
 
-    if ( 'do-core-upgrade' != $action && 'do-core-reinstall' != $action ) {
+    if ( 'do-core-upgrade' !== $action && 'do-core-reinstall' !== $action ) {
         return;
     }