Changeset 47808 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (13 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -863 +863 @@
     if ( $posts ) {
         foreach ( $posts as $post ) {
-            if ( '' == $post->post_name ) {
+            if ( '' === $post->post_name ) {
                 $newtitle = sanitize_title( $post->post_title );
                 $wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET post_name = %s WHERE ID = %d", $newtitle, $post->ID ) );
@@ -872 +872 @@
     $categories = $wpdb->get_results( "SELECT cat_ID, cat_name, category_nicename FROM $wpdb->categories" );
     foreach ( $categories as $category ) {
-        if ( '' == $category->category_nicename ) {
+        if ( '' === $category->category_nicename ) {
             $newtitle = sanitize_title( $category->cat_name );
             $wpdb->update( $wpdb->categories, array( 'category_nicename' => $newtitle ), array( 'cat_ID' => $category->cat_ID ) );
@@ -948 +948 @@
     $users = $wpdb->get_results( "SELECT ID, user_nickname, user_nicename FROM $wpdb->users" );
     foreach ( $users as $user ) {
-        if ( '' == $user->user_nicename ) {
+        if ( '' === $user->user_nicename ) {
             $newname = sanitize_title( $user->user_nickname );
             $wpdb->update( $wpdb->users, array( 'user_nicename' => $newname ), array( 'ID' => $user->ID ) );
@@ -983 +983 @@
      * <michel_v> I just slapped myself silly for not thinking about it earlier.
      */
-    $got_gmt_fields = ! ( $wpdb->get_var( "SELECT MAX(post_date_gmt) FROM $wpdb->posts" ) == '0000-00-00 00:00:00' );
+    $got_gmt_fields = ( '0000-00-00 00:00:00' !== $wpdb->get_var( "SELECT MAX(post_date_gmt) FROM $wpdb->posts" ) );
 
     if ( ! $got_gmt_fields ) {
@@ -1227 +1227 @@
                 $type   = 'post';
 
-                if ( 'static' == $status ) {
+                if ( 'static' === $status ) {
                     $status = 'publish';
                     $type   = 'page';
-                } elseif ( 'attachment' == $status ) {
+                } elseif ( 'attachment' === $status ) {
                     $status = 'inherit';
                     $type   = 'attachment';
@@ -1358 +1358 @@
         $term_id  = (int) $post->category_id;
         $taxonomy = 'category';
-        if ( ! empty( $post->rel_type ) && 'tag' == $post->rel_type ) {
+        if ( ! empty( $post->rel_type ) && 'tag' === $post->rel_type ) {
             $taxonomy = 'tag';
         }
@@ -1476 +1476 @@
     $terms = $wpdb->get_results( "SELECT term_taxonomy_id, taxonomy FROM $wpdb->term_taxonomy" );
     foreach ( (array) $terms as $term ) {
-        if ( ( 'post_tag' == $term->taxonomy ) || ( 'category' == $term->taxonomy ) ) {
+        if ( 'post_tag' === $term->taxonomy || 'category' === $term->taxonomy ) {
             $count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(*) FROM $wpdb->term_relationships, $wpdb->posts WHERE $wpdb->posts.ID = $wpdb->term_relationships.object_id AND post_status = 'publish' AND post_type = 'post' AND term_taxonomy_id = %d", $term->term_taxonomy_id ) );
         } else {
@@ -1816 +1816 @@
 
     if ( $wp_current_db_version < 20080 ) {
-        if ( 'yes' == $wpdb->get_var( "SELECT autoload FROM $wpdb->options WHERE option_name = 'uninstall_plugins'" ) ) {
+        if ( 'yes' === $wpdb->get_var( "SELECT autoload FROM $wpdb->options WHERE option_name = 'uninstall_plugins'" ) ) {
             $uninstall_plugins = get_option( 'uninstall_plugins' );
             delete_option( 'uninstall_plugins' );
@@ -2292 +2292 @@
             $indexes = $wpdb->get_results( "SHOW INDEXES FROM $wpdb->signups" );
             foreach ( $indexes as $index ) {
-                if ( 'domain_path' == $index->Key_name && 'domain' == $index->Column_name && 140 != $index->Sub_part ) {
+                if ( 'domain_path' === $index->Key_name && 'domain' === $index->Column_name && 140 != $index->Sub_part ) {
                     $upgrade = true;
                     break;
@@ -2502 +2502 @@
     if ( $options ) {
         foreach ( $options as $option ) {
-            if ( 'siteurl' == $option->option_name || 'home' == $option->option_name || 'category_base' == $option->option_name ) {
+            if ( 'siteurl' === $option->option_name || 'home' === $option->option_name || 'category_base' === $option->option_name ) {
                 $option->option_value = untrailingslashit( $option->option_value );
             }
@@ -2536 +2536 @@
     $option = $wpdb->get_var( $wpdb->prepare( "SELECT option_value FROM $wpdb->options WHERE option_name = %s", $setting ) );
 
-    if ( 'home' === $setting && '' == $option ) {
+    if ( 'home' === $setting && '' === $option ) {
         return __get_option( 'siteurl' );
     }
 
-    if ( 'siteurl' === $setting || 'home' === $setting || 'category_base' === $setting || 'tag_base' === $setting ) {
+    if ( in_array( $setting, array( 'siteurl', 'home', 'category_base', 'tag_base' ), true ) ) {
         $option = untrailingslashit( $option );
     }
@@ -2916 +2916 @@
                 // For each column in the index.
                 foreach ( $index_data['columns'] as $column_data ) {
-                    if ( '' != $index_columns ) {
+                    if ( '' !== $index_columns ) {
                         $index_columns .= ',';
                     }
@@ -3271 +3271 @@
 
     foreach ( (array) $plugins as $plugin ) {
-        if ( basename( $plugin ) == 'widgets.php' ) {
+        if ( 'widgets.php' === basename( $plugin ) ) {
             array_splice( $plugins, array_search( $plugin, $plugins, true ), 1 );
             update_option( 'active_plugins', $plugins );