Changeset 47808 for trunk/src/wp-admin/includes/user.php

Timestamp:

05/16/2020 06:40:52 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/user.php (modified) (4 diffs)

trunk/src/wp-admin/includes/user.php

@@ -133 +133 @@
     }
 
-    $user->comment_shortcuts = isset( $_POST['comment_shortcuts'] ) && 'true' == $_POST['comment_shortcuts'] ? 'true' : '';
+    $user->comment_shortcuts = isset( $_POST['comment_shortcuts'] ) && 'true' === $_POST['comment_shortcuts'] ? 'true' : '';
 
     $user->use_ssl = 0;
@@ -143 +143 @@
 
     /* checking that username has been typed */
-    if ( '' == $user->user_login ) {
+    if ( '' === $user->user_login ) {
         $errors->add( 'user_login', __( '<strong>Error</strong>: Please enter a username.' ) );
     }
@@ -475 +475 @@
 
     // get_user_setting() = JS-saved UI setting. Else no-js-fallback code.
-    if ( 'hide' == get_user_setting( 'default_password_nag' ) || isset( $_GET['default_password_nag'] ) && '0' == $_GET['default_password_nag'] ) {
+    if ( 'hide' === get_user_setting( 'default_password_nag' )
+        || isset( $_GET['default_password_nag'] ) && '0' == $_GET['default_password_nag']
+    ) {
         delete_user_setting( 'default_password_nag' );
         update_user_option( $user_ID, 'default_password_nag', false, true );
@@ -510 +512 @@
     global $pagenow;
     // Short-circuit it.
-    if ( 'profile.php' == $pagenow || ! get_user_option( 'default_password_nag' ) ) {
+    if ( 'profile.php' === $pagenow || ! get_user_option( 'default_password_nag' ) ) {
         return;
     }