Changeset 47808 for trunk/src/wp-admin/options.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/options.php (modified) (6 diffs)

trunk/src/wp-admin/options.php

@@ -65 +65 @@
     wp_redirect( admin_url( $redirect ) );
     exit;
-} elseif ( ! empty( $_GET['dismiss'] ) && 'new_admin_email' == $_GET['dismiss'] ) {
+} elseif ( ! empty( $_GET['dismiss'] ) && 'new_admin_email' === $_GET['dismiss'] ) {
     check_admin_referer( 'dismiss-' . get_current_blog_id() . '-new_admin_email' );
     delete_option( 'adminhash' );
@@ -205 +205 @@
 $whitelist_options = apply_filters( 'whitelist_options', $whitelist_options );
 
-if ( 'update' == $action ) { // We are saving settings sent from a settings page.
-    if ( 'options' == $option_page && ! isset( $_POST['option_page'] ) ) { // This is for back compat and will eventually be removed.
+if ( 'update' === $action ) { // We are saving settings sent from a settings page.
+    if ( 'options' === $option_page && ! isset( $_POST['option_page'] ) ) { // This is for back compat and will eventually be removed.
         $unregistered = true;
         check_admin_referer( 'update-options' );
@@ -224 +224 @@
     }
 
-    if ( 'options' == $option_page ) {
+    if ( 'options' === $option_page ) {
         if ( is_multisite() && ! current_user_can( 'manage_network_options' ) ) {
             wp_die( __( 'Sorry, you are not allowed to modify unregistered settings for this site.' ) );
@@ -233 +233 @@
     }
 
-    if ( 'general' == $option_page ) {
+    if ( 'general' === $option_page ) {
         // Handle custom date/time formats.
-        if ( ! empty( $_POST['date_format'] ) && isset( $_POST['date_format_custom'] ) && '\c\u\s\t\o\m' == wp_unslash( $_POST['date_format'] ) ) {
+        if ( ! empty( $_POST['date_format'] ) && isset( $_POST['date_format_custom'] )
+            && '\c\u\s\t\o\m' === wp_unslash( $_POST['date_format'] )
+        ) {
             $_POST['date_format'] = $_POST['date_format_custom'];
         }
-        if ( ! empty( $_POST['time_format'] ) && isset( $_POST['time_format_custom'] ) && '\c\u\s\t\o\m' == wp_unslash( $_POST['time_format'] ) ) {
+
+        if ( ! empty( $_POST['time_format'] ) && isset( $_POST['time_format_custom'] )
+            && '\c\u\s\t\o\m' === wp_unslash( $_POST['time_format'] )
+        ) {
             $_POST['time_format'] = $_POST['time_format_custom'];
         }
+
         // Map UTC+- timezones to gmt_offsets and set timezone_string to empty.
         if ( ! empty( $_POST['timezone_string'] ) && preg_match( '/^UTC[+-]/', $_POST['timezone_string'] ) ) {
@@ -336 +342 @@
 foreach ( (array) $options as $option ) :
     $disabled = false;
-    if ( '' == $option->option_name ) {
+
+    if ( '' === $option->option_name ) {
         continue;
     }
+
     if ( is_serialized( $option->option_value ) ) {
         if ( is_serialized_string( $option->option_value ) ) {
@@ -355 +363 @@
         $class               = 'all-options';
     }
+
     $name = esc_attr( $option->option_name );
     ?>