Changeset 47808 for trunk/src/wp-admin/plugins.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/plugins.php (modified) (4 diffs)

trunk/src/wp-admin/plugins.php

@@ -44 +44 @@
             $result = activate_plugin( $plugin, self_admin_url( 'plugins.php?error=true&plugin=' . urlencode( $plugin ) ), is_network_admin() );
             if ( is_wp_error( $result ) ) {
-                if ( 'unexpected_output' == $result->get_error_code() ) {
+                if ( 'unexpected_output' === $result->get_error_code() ) {
                     $redirect = self_admin_url( 'plugins.php?error=true&charsout=' . strlen( $result->get_error_data() ) . '&plugin=' . urlencode( $plugin ) . "&plugin_status=$status&paged=$page&s=$s" );
                     wp_redirect( add_query_arg( '_error_nonce', wp_create_nonce( 'plugin-activation-error_' . $plugin ), $redirect ) );
@@ -63 +63 @@
             }
 
-            if ( isset( $_GET['from'] ) && 'import' == $_GET['from'] ) {
+            if ( isset( $_GET['from'] ) && 'import' === $_GET['from'] ) {
                 // Overrides the ?error=true one above and redirects to the Imports page, stripping the -importer suffix.
                 wp_redirect( self_admin_url( 'import.php?import=' . str_replace( '-importer', '', dirname( $plugin ) ) ) );
-            } elseif ( isset( $_GET['from'] ) && 'press-this' == $_GET['from'] ) {
+            } elseif ( isset( $_GET['from'] ) && 'press-this' === $_GET['from'] ) {
                 wp_redirect( self_admin_url( 'press-this.php' ) );
             } else {
@@ -293 +293 @@
                     $plugin_slug = dirname( $plugin );
 
-                    if ( '.' == $plugin_slug ) {
+                    if ( '.' === $plugin_slug ) {
                         $data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
                         if ( $data ) {
@@ -580 +580 @@
 <?php elseif ( isset( $_GET['deactivate-multi'] ) ) : ?>
     <div id="message" class="updated notice is-dismissible"><p><?php _e( 'Selected plugins deactivated.' ); ?></p></div>
-<?php elseif ( 'update-selected' == $action ) : ?>
+<?php elseif ( 'update-selected' === $action ) : ?>
     <div id="message" class="updated notice is-dismissible"><p><?php _e( 'All selected plugins are up to date.' ); ?></p></div>
 <?php elseif ( isset( $_GET['resume'] ) ) : ?>