Changeset 47808 for trunk/src/wp-admin/update-core.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/update-core.php (modified) (7 diffs)

trunk/src/wp-admin/update-core.php

@@ -691 +691 @@
 
 $upgrade_error = false;
-if ( ( 'do-theme-upgrade' == $action || ( 'do-plugin-upgrade' == $action && ! isset( $_GET['plugins'] ) ) )
+if ( ( 'do-theme-upgrade' === $action || ( 'do-plugin-upgrade' === $action && ! isset( $_GET['plugins'] ) ) )
     && ! isset( $_POST['checked'] ) ) {
-    $upgrade_error = 'do-theme-upgrade' == $action ? 'themes' : 'plugins';
+    $upgrade_error = ( 'do-theme-upgrade' === $action ) ? 'themes' : 'plugins';
     $action        = 'upgrade-core';
 }
@@ -732 +732 @@
 );
 
-if ( 'upgrade-core' == $action ) {
+if ( 'upgrade-core' === $action ) {
     // Force a update check when requested.
     $force_check = ! empty( $_GET['force-check'] );
@@ -796 +796 @@
     require_once ABSPATH . 'wp-admin/admin-footer.php';
 
-} elseif ( 'do-core-upgrade' == $action || 'do-core-reinstall' == $action ) {
+} elseif ( 'do-core-upgrade' === $action || 'do-core-reinstall' === $action ) {
 
     if ( ! current_user_can( 'update_core' ) ) {
@@ -812 +812 @@
 
     require_once ABSPATH . 'wp-admin/admin-header.php';
-    if ( 'do-core-reinstall' == $action ) {
+    if ( 'do-core-reinstall' === $action ) {
         $reinstall = true;
     } else {
@@ -832 +832 @@
     require_once ABSPATH . 'wp-admin/admin-footer.php';
 
-} elseif ( 'do-plugin-upgrade' == $action ) {
+} elseif ( 'do-plugin-upgrade' === $action ) {
 
     if ( ! current_user_can( 'update_plugins' ) ) {
@@ -870 +870 @@
     require_once ABSPATH . 'wp-admin/admin-footer.php';
 
-} elseif ( 'do-theme-upgrade' == $action ) {
+} elseif ( 'do-theme-upgrade' === $action ) {
 
     if ( ! current_user_can( 'update_themes' ) ) {
@@ -910 +910 @@
     require_once ABSPATH . 'wp-admin/admin-footer.php';
 
-} elseif ( 'do-translation-upgrade' == $action ) {
+} elseif ( 'do-translation-upgrade' === $action ) {
 
     if ( ! current_user_can( 'update_languages' ) ) {