Changeset 47808 for trunk/src/wp-includes/category-template.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/category-template.php (modified) (10 diffs)

trunk/src/wp-includes/category-template.php

@@ -156 +156 @@
 
         $thelist = '';
-        if ( '' == $separator ) {
+        if ( '' === $separator ) {
                 $thelist .= '<ul class="post-categories">';
                 foreach ( $categories as $category ) {
@@ -352 +352 @@
 
         // Back compat.
-        if ( isset( $args['type'] ) && 'link' == $args['type'] ) {
+        if ( isset( $args['type'] ) && 'link' === $args['type'] ) {
                 _deprecated_argument(
                         __FUNCTION__,
@@ -560 +560 @@
 
         if ( ! isset( $parsed_args['class'] ) ) {
-                $parsed_args['class'] = ( 'category' == $parsed_args['taxonomy'] ) ? 'categories' : $parsed_args['taxonomy'];
+                $parsed_args['class'] = ( 'category' === $parsed_args['taxonomy'] ) ? 'categories' : $parsed_args['taxonomy'];
         }
 
@@ -573 +573 @@
 
         $output = '';
-        if ( $parsed_args['title_li'] && 'list' == $parsed_args['style'] && ( ! empty( $categories ) || ! $parsed_args['hide_title_if_empty'] ) ) {
+
+        if ( $parsed_args['title_li'] && 'list' === $parsed_args['style']
+                && ( ! empty( $categories ) || ! $parsed_args['hide_title_if_empty'] )
+        ) {
                 $output = '<li class="' . esc_attr( $parsed_args['class'] ) . '">' . $parsed_args['title_li'] . '<ul>';
         }
+
         if ( empty( $categories ) ) {
                 if ( ! empty( $show_option_none ) ) {
-                        if ( 'list' == $parsed_args['style'] ) {
+                        if ( 'list' === $parsed_args['style'] ) {
                                 $output .= '<li class="cat-item-none">' . $show_option_none . '</li>';
                         } else {
@@ -605 +609 @@
                         // Fallback for the 'All' link is the posts page.
                         if ( ! $posts_page ) {
-                                if ( 'page' == get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) ) {
+                                if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) ) {
                                         $posts_page = get_permalink( get_option( 'page_for_posts' ) );
                                 } else {
@@ -613 +617 @@
 
                         $posts_page = esc_url( $posts_page );
-                        if ( 'list' == $parsed_args['style'] ) {
+                        if ( 'list' === $parsed_args['style'] ) {
                                 $output .= "<li class='cat-item-all'><a href='$posts_page'>$show_option_all</a></li>";
                         } else {
@@ -635 +639 @@
         }
 
-        if ( $parsed_args['title_li'] && 'list' == $parsed_args['style'] && ( ! empty( $categories ) || ! $parsed_args['hide_title_if_empty'] ) ) {
+        if ( $parsed_args['title_li'] && 'list' === $parsed_args['style']
+                && ( ! empty( $categories ) || ! $parsed_args['hide_title_if_empty'] )
+        ) {
                 $output .= '</ul></li>';
         }
@@ -714 +720 @@
 
         foreach ( $tags as $key => $tag ) {
-                if ( 'edit' == $args['link'] ) {
+                if ( 'edit' === $args['link'] ) {
                         $link = get_edit_term_link( $tag->term_id, $tag->taxonomy, $args['post_type'] );
                 } else {
@@ -741 +747 @@
         $return = apply_filters( 'wp_tag_cloud', $return, $args );
 
-        if ( 'array' == $args['format'] || empty( $args['echo'] ) ) {
+        if ( 'array' === $args['format'] || empty( $args['echo'] ) ) {
                 return $return;
         }
@@ -940 +946 @@
                 $tags_data[] = array(
                         'id'              => $tag_id,
-                        'url'             => '#' != $tag->link ? $tag->link : '#',
-                        'role'            => '#' != $tag->link ? '' : ' role="button"',
+                        'url'             => ( '#' !== $tag->link ) ? $tag->link : '#',
+                        'role'            => ( '#' !== $tag->link ) ? '' : ' role="button"',
                         'name'            => $tag->name,
                         'formatted_count' => $formatted_count,