Changeset 47808 for trunk/src/wp-includes/class-wp-rewrite.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-rewrite.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-rewrite.php

@@ -527 +527 @@
                 $tok_index = 1;
                 foreach ( (array) $tokens[0] as $token ) {
-                        if ( '%post_id%' == $token && ( $tok_index <= 3 ) ) {
+                        if ( '%post_id%' === $token && ( $tok_index <= 3 ) ) {
                                 $front = $front . 'date/';
                                 break;
@@ -1262 +1262 @@
                 // robots.txt -- only if installed at the root.
                 $home_path      = parse_url( home_url() );
-                $robots_rewrite = ( empty( $home_path['path'] ) || '/' == $home_path['path'] ) ? array( 'robots\.txt$' => $this->index . '?robots=1' ) : array();
+                $robots_rewrite = ( empty( $home_path['path'] ) || '/' === $home_path['path'] ) ? array( 'robots\.txt$' => $this->index . '?robots=1' ) : array();
 
                 // favicon.ico -- only if installed at the root.
-                $favicon_rewrite = ( empty( $home_path['path'] ) || '/' == $home_path['path'] ) ? array( 'favicon\.ico$' => $this->index . '?favicon=1' ) : array();
+                $favicon_rewrite = ( empty( $home_path['path'] ) || '/' === $home_path['path'] ) ? array( 'favicon\.ico$' => $this->index . '?favicon=1' ) : array();
 
                 // Old feed and service files.
@@ -1405 +1405 @@
                          */
                         $rules = apply_filters( "{$permastructname}_rewrite_rules", $rules );
-                        if ( 'post_tag' == $permastructname ) {
+
+                        if ( 'post_tag' === $permastructname ) {
 
                                 /**
@@ -1648 +1649 @@
                         $this->add_external_rule( $regex, $query );
                 } else {
-                        if ( 'bottom' == $after ) {
+                        if ( 'bottom' === $after ) {
                                 $this->extra_rules = array_merge( $this->extra_rules, array( $regex => $query ) );
                         } else {
@@ -1855 +1856 @@
                 unset( $this->feed_structure );
                 unset( $this->comment_feed_structure );
-                $this->use_trailing_slashes = ( '/' == substr( $this->permalink_structure, -1, 1 ) );
+
+                $this->use_trailing_slashes = ( '/' === substr( $this->permalink_structure, -1, 1 ) );
 
                 // Enable generic rules for pages if permalink structure doesn't begin with a wildcard.