Changeset 47808 for trunk/src/wp-includes/class-wp-term-query.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-term-query.php (modified) (10 diffs)

trunk/src/wp-includes/class-wp-term-query.php

@@ -254 +254 @@
         }
 
-        if ( 'all' == $query['get'] ) {
+        if ( 'all' === $query['get'] ) {
             $query['childless']    = false;
             $query['child_of']     = 0;
@@ -342 +342 @@
         }
 
-        if ( 'all' == $args['get'] ) {
+        if ( 'all' === $args['get'] ) {
             $args['childless']    = false;
             $args['child_of']     = 0;
@@ -383 +383 @@
 
             if ( ! $in_hierarchy ) {
-                if ( 'count' == $args['fields'] ) {
+                if ( 'count' === $args['fields'] ) {
                     return 0;
                 } else {
@@ -546 +546 @@
 
         $hierarchical = $args['hierarchical'];
-        if ( 'count' == $args['fields'] ) {
+        if ( 'count' === $args['fields'] ) {
             $hierarchical = false;
         }
@@ -710 +710 @@
         }
 
-        if ( 'count' == $_fields ) {
+        if ( 'count' === $_fields ) {
             $count = $wpdb->get_var( $this->request );
             wp_cache_set( $cache_key, $count, 'terms' );
@@ -717 +717 @@
 
         $terms = $wpdb->get_results( $this->request );
-        if ( 'all' == $_fields || 'all_with_object_id' === $_fields ) {
+
+        if ( 'all' === $_fields || 'all_with_object_id' === $_fields ) {
             update_term_cache( $terms );
         }
@@ -742 +743 @@
 
         // Update term counts to include children.
-        if ( $args['pad_counts'] && 'all' == $_fields ) {
+        if ( $args['pad_counts'] && 'all' === $_fields ) {
             foreach ( $taxonomies as $_tax ) {
                 _pad_term_counts( $terms, $_tax );
@@ -774 +775 @@
          * removed.
          */
-        if ( ! empty( $args['object_ids'] ) && 'all_with_object_id' != $_fields ) {
+        if ( ! empty( $args['object_ids'] ) && 'all_with_object_id' !== $_fields ) {
             $_tt_ids = array();
             $_terms  = array();
@@ -790 +791 @@
 
         $_terms = array();
-        if ( 'id=>parent' == $_fields ) {
+        if ( 'id=>parent' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[ $term->term_id ] = $term->parent;
             }
-        } elseif ( 'ids' == $_fields ) {
+        } elseif ( 'ids' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[] = (int) $term->term_id;
             }
-        } elseif ( 'tt_ids' == $_fields ) {
+        } elseif ( 'tt_ids' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[] = (int) $term->term_taxonomy_id;
             }
-        } elseif ( 'names' == $_fields ) {
+        } elseif ( 'names' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[] = $term->name;
             }
-        } elseif ( 'slugs' == $_fields ) {
+        } elseif ( 'slugs' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[] = $term->slug;
             }
-        } elseif ( 'id=>name' == $_fields ) {
+        } elseif ( 'id=>name' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[ $term->term_id ] = $term->name;
             }
-        } elseif ( 'id=>slug' == $_fields ) {
+        } elseif ( 'id=>slug' === $_fields ) {
             foreach ( $terms as $term ) {
                 $_terms[ $term->term_id ] = $term->slug;
@@ -863 +864 @@
         } elseif ( 'term_order' === $_orderby ) {
             $orderby = 'tr.term_order';
-        } elseif ( 'include' == $_orderby && ! empty( $this->query_vars['include'] ) ) {
+        } elseif ( 'include' === $_orderby && ! empty( $this->query_vars['include'] ) ) {
             $include = implode( ',', wp_parse_id_list( $this->query_vars['include'] ) );
             $orderby = "FIELD( t.term_id, $include )";
-        } elseif ( 'slug__in' == $_orderby && ! empty( $this->query_vars['slug'] ) && is_array( $this->query_vars['slug'] ) ) {
+        } elseif ( 'slug__in' === $_orderby && ! empty( $this->query_vars['slug'] ) && is_array( $this->query_vars['slug'] ) ) {
             $slugs   = implode( "', '", array_map( 'sanitize_title_for_query', $this->query_vars['slug'] ) );
             $orderby = "FIELD( t.slug, '" . $slugs . "')";
-        } elseif ( 'none' == $_orderby ) {
+        } elseif ( 'none' === $_orderby ) {
             $orderby = '';
-        } elseif ( empty( $_orderby ) || 'id' == $_orderby || 'term_id' === $_orderby ) {
+        } elseif ( empty( $_orderby ) || 'id' === $_orderby || 'term_id' === $_orderby ) {
             $orderby = 't.term_id';
         } else {