Changeset 47808 for trunk/src/wp-includes/class-wp-user-query.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-user-query.php (modified) (8 diffs)

trunk/src/wp-includes/class-wp-user-query.php

@@ -243 +243 @@
             }
             $this->query_fields = implode( ',', $this->query_fields );
-        } elseif ( 'all' == $qv['fields'] ) {
+        } elseif ( 'all' === $qv['fields'] ) {
             $this->query_fields = "$wpdb->users.*";
         } else {
@@ -321 +321 @@
         $this->meta_query->parse_query_vars( $qv );
 
-        if ( isset( $qv['who'] ) && 'authors' == $qv['who'] && $blog_id ) {
+        if ( isset( $qv['who'] ) && 'authors' === $qv['who'] && $blog_id ) {
             $who_query = array(
                 'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'user_level',
@@ -615 +615 @@
             $this->request = "SELECT $this->query_fields $this->query_from $this->query_where $this->query_orderby $this->query_limit";
 
-            if ( is_array( $qv['fields'] ) || 'all' == $qv['fields'] ) {
+            if ( is_array( $qv['fields'] ) || 'all' === $qv['fields'] ) {
                 $this->results = $wpdb->get_results( $this->request );
             } else {
@@ -643 +643 @@
         }
 
-        if ( 'all_with_meta' == $qv['fields'] ) {
+        if ( 'all_with_meta' === $qv['fields'] ) {
             cache_users( $this->results );
 
@@ -652 +652 @@
 
             $this->results = $r;
-        } elseif ( 'all' == $qv['fields'] ) {
+        } elseif ( 'all' === $qv['fields'] ) {
             foreach ( $this->results as $key => $user ) {
                 $this->results[ $key ] = new WP_User( $user, '', $qv['blog_id'] );
@@ -704 +704 @@
 
         $searches      = array();
-        $leading_wild  = ( 'leading' == $wild || 'both' == $wild ) ? '%' : '';
-        $trailing_wild = ( 'trailing' == $wild || 'both' == $wild ) ? '%' : '';
+        $leading_wild  = ( 'leading' === $wild || 'both' === $wild ) ? '%' : '';
+        $trailing_wild = ( 'trailing' === $wild || 'both' === $wild ) ? '%' : '';
         $like          = $leading_wild . $wpdb->esc_like( $string ) . $trailing_wild;
 
         foreach ( $cols as $col ) {
-            if ( 'ID' == $col ) {
+            if ( 'ID' === $col ) {
                 $searches[] = $wpdb->prepare( "$col = %s", $string );
             } else {
@@ -761 +761 @@
         } elseif ( in_array( $orderby, array( 'user_login', 'user_nicename', 'user_email', 'user_url', 'user_registered' ), true ) ) {
             $_orderby = $orderby;
-        } elseif ( 'name' == $orderby || 'display_name' == $orderby ) {
+        } elseif ( 'name' === $orderby || 'display_name' === $orderby ) {
             $_orderby = 'display_name';
-        } elseif ( 'post_count' == $orderby ) {
+        } elseif ( 'post_count' === $orderby ) {
             // @todo Avoid the JOIN.
             $where             = get_posts_by_author_sql( 'post' );
@@ -774 +774 @@
             ";
             $_orderby          = 'post_count';
-        } elseif ( 'ID' == $orderby || 'id' == $orderby ) {
+        } elseif ( 'ID' === $orderby || 'id' === $orderby ) {
             $_orderby = 'ID';
-        } elseif ( 'meta_value' == $orderby || $this->get( 'meta_key' ) == $orderby ) {
+        } elseif ( 'meta_value' === $orderby || $this->get( 'meta_key' ) == $orderby ) {
             $_orderby = "$wpdb->usermeta.meta_value";
-        } elseif ( 'meta_value_num' == $orderby ) {
+        } elseif ( 'meta_value_num' === $orderby ) {
             $_orderby = "$wpdb->usermeta.meta_value+0";
         } elseif ( 'include' === $orderby && ! empty( $this->query_vars['include'] ) ) {