Changeset 47808 for trunk/src/wp-includes/comment-template.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/comment-template.php (modified) (18 diffs)

trunk/src/wp-includes/comment-template.php

@@ -194 +194 @@
 
     if ( ( ! empty( $email ) ) && ( '@' !== $email ) ) {
-        $display = ( '' != $linktext ) ? $linktext : $email;
+        $display = ( '' !== $linktext ) ? $linktext : $email;
         $return  = $before;
         $return .= sprintf( '<a href="%1$s">%2$s</a>', esc_url( 'mailto:' . $email ), esc_html( $display ) );
@@ -222 +222 @@
     $author  = get_comment_author( $comment );
 
-    if ( empty( $url ) || 'http://' == $url ) {
+    if ( empty( $url ) || 'http://' === $url ) {
         $return = $author;
     } else {
@@ -309 +309 @@
     $id      = 0;
     if ( ! empty( $comment ) ) {
-        $author_url = ( 'http://' == $comment->comment_author_url ) ? '' : $comment->comment_author_url;
+        $author_url = ( 'http://' === $comment->comment_author_url ) ? '' : $comment->comment_author_url;
         $url        = esc_url( $author_url, array( 'http', 'https' ) );
         $id         = $comment->comment_ID;
@@ -377 +377 @@
 function get_comment_author_url_link( $linktext = '', $before = '', $after = '', $comment = 0 ) {
     $url     = get_comment_author_url( $comment );
-    $display = ( '' != $linktext ) ? $linktext : $url;
+    $display = ( '' !== $linktext ) ? $linktext : $url;
     $display = str_replace( 'http://www.', '', $display );
     $display = str_replace( 'http://', '', $display );
 
-    if ( '/' == substr( $display, -1 ) ) {
+    if ( '/' === substr( $display, -1 ) ) {
         $display = substr( $display, 0, -1 );
     }
@@ -551 +551 @@
 function get_comment_date( $format = '', $comment_ID = 0 ) {
     $comment = get_comment( $comment_ID );
-    if ( '' == $format ) {
+
+    if ( '' === $format ) {
         $date = mysql2date( get_option( 'date_format' ), $comment->comment_date );
     } else {
         $date = mysql2date( $format, $comment->comment_date );
     }
+
     /**
      * Filters the returned comment date.
@@ -1038 +1040 @@
 
     $comment_date = $gmt ? $comment->comment_date_gmt : $comment->comment_date;
-    if ( '' == $format ) {
+
+    if ( '' === $format ) {
         $date = mysql2date( get_option( 'time_format' ), $comment_date, $translate );
     } else {
@@ -1081 +1084 @@
 function get_comment_type( $comment_ID = 0 ) {
     $comment = get_comment( $comment_ID );
-    if ( '' == $comment->comment_type ) {
+
+    if ( '' === $comment->comment_type ) {
         $comment->comment_type = 'comment';
     }
@@ -1142 +1146 @@
  */
 function get_trackback_url() {
-    if ( '' != get_option( 'permalink_structure' ) ) {
+    if ( get_option( 'permalink_structure' ) ) {
         $tb_url = trailingslashit( get_permalink() ) . user_trailingslashit( 'trackback', 'single_trackback' );
     } else {
@@ -1236 +1240 @@
 
     $post_id = $_post ? $_post->ID : 0;
-    $open    = ( 'open' == $_post->comment_status );
+    $open    = ( 'open' === $_post->comment_status );
 
     /**
@@ -1266 +1270 @@
 
     $post_id = $_post ? $_post->ID : 0;
-    $open    = ( 'open' == $_post->ping_status );
+    $open    = ( 'open' === $_post->ping_status );
 
     /**
@@ -1506 +1510 @@
 
     $overridden_cpage = false;
+
     if ( '' == get_query_var( 'cpage' ) && $wp_query->max_num_comment_pages > 1 ) {
-        set_query_var( 'cpage', 'newest' == get_option( 'default_comments_page' ) ? get_comment_pages_count() : 1 );
+        set_query_var( 'cpage', 'newest' === get_option( 'default_comments_page' ) ? get_comment_pages_count() : 1 );
         $overridden_cpage = true;
     }
@@ -1516 +1521 @@
 
     $theme_template = STYLESHEETPATH . $file;
+
     /**
      * Filters the path to the theme template file used for the comments template.
@@ -1524 +1530 @@
      */
     $include = apply_filters( 'comments_template', $theme_template );
+
     if ( file_exists( $include ) ) {
         require $include;
@@ -2061 +2068 @@
             return;
         }
-        if ( 'all' != $parsed_args['type'] ) {
+        if ( 'all' !== $parsed_args['type'] ) {
             $comments_by_type = separate_comments( $comments );
             if ( empty( $comments_by_type[ $parsed_args['type'] ] ) ) {
@@ -2102 +2109 @@
                 $comments = get_comments( $comment_args );
 
-                if ( 'all' != $parsed_args['type'] ) {
+                if ( 'all' !== $parsed_args['type'] ) {
                     $comments_by_type = separate_comments( $comments );
                     if ( empty( $comments_by_type[ $parsed_args['type'] ] ) ) {
@@ -2119 +2126 @@
                 return;
             }
-            if ( 'all' != $parsed_args['type'] ) {
+            if ( 'all' !== $parsed_args['type'] ) {
                 if ( empty( $wp_query->comments_by_type ) ) {
                     $wp_query->comments_by_type = separate_comments( $wp_query->comments );
@@ -2175 +2182 @@
         } else {
             $threaded            = ( -1 != $parsed_args['max_depth'] );
-            $parsed_args['page'] = ( 'newest' == get_option( 'default_comments_page' ) ) ? get_comment_pages_count( $_comments, $parsed_args['per_page'], $threaded ) : 1;
+            $parsed_args['page'] = ( 'newest' === get_option( 'default_comments_page' ) ) ? get_comment_pages_count( $_comments, $parsed_args['per_page'], $threaded ) : 1;
             set_query_var( 'cpage', $parsed_args['page'] );
         }
@@ -2186 +2193 @@
 
     if ( null === $parsed_args['reverse_top_level'] ) {
-        $parsed_args['reverse_top_level'] = ( 'desc' == get_option( 'comment_order' ) );
+        $parsed_args['reverse_top_level'] = ( 'desc' === get_option( 'comment_order' ) );
     }