Changeset 47808 for trunk/src/wp-includes/formatting.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/formatting.php (modified) (16 diffs)

trunk/src/wp-includes/formatting.php

@@ -380 +380 @@
             $sentence = preg_replace( $quote_pattern, $close_quote, $sentence );
         }
-        if ( '"' == $needle && false !== strpos( $sentence, '"' ) ) {
+        if ( '"' === $needle && false !== strpos( $sentence, '"' ) ) {
             $sentence = str_replace( '"', $close_quote, $sentence );
         }
@@ -1939 +1939 @@
         $locale = get_locale();
 
-        if ( 'de_DE' == $locale || 'de_DE_formal' == $locale || 'de_CH' == $locale || 'de_CH_informal' == $locale ) {
+        if ( in_array( $locale, array( 'de_DE', 'de_DE_formal', 'de_CH', 'de_CH_informal' ), true ) ) {
             $chars['Ä'] = 'Ae';
             $chars['ä'] = 'ae';
@@ -2180 +2180 @@
     $raw_title = $title;
 
-    if ( 'save' == $context ) {
+    if ( 'save' === $context ) {
         $title = remove_accents( $title );
     }
@@ -2247 +2247 @@
     $title = strtolower( $title );
 
-    if ( 'save' == $context ) {
+    if ( 'save' === $context ) {
         // Convert &nbsp, &ndash, and &mdash to hyphens.
         $title = str_replace( array( '%c2%a0', '%e2%80%93', '%e2%80%94' ), '-', $title );
@@ -2355 +2355 @@
     $sanitized = preg_replace( '/[^A-Za-z0-9_-]/', '', $sanitized );
 
-    if ( '' == $sanitized && $fallback ) {
+    if ( '' === $sanitized && $fallback ) {
         return sanitize_html_class( $fallback );
     }
@@ -2837 +2837 @@
     $url = $matches[2];
 
-    if ( ')' == $matches[3] && strpos( $url, '(' ) ) {
+    if ( ')' === $matches[3] && strpos( $url, '(' ) ) {
         // If the trailing character is a closing parethesis, and the URL has an opening parenthesis in it,
         // add the closing parenthesis to the URL. Then we can let the parenthesis balancer do its thing below.
@@ -3371 +3371 @@
 
             // If we're in an ignore block, wait until we find its closing tag.
-            if ( '' == $ignore_block_element && preg_match( '/^<(' . $tags_to_ignore . ')[^>]*>/', $content, $matches ) ) {
+            if ( '' === $ignore_block_element && preg_match( '/^<(' . $tags_to_ignore . ')[^>]*>/', $content, $matches ) ) {
                 $ignore_block_element = $matches[1];
             }
 
             // If it's not a tag and not in ignore block.
-            if ( '' == $ignore_block_element && strlen( $content ) > 0 && '<' != $content[0] ) {
+            if ( '' === $ignore_block_element && strlen( $content ) > 0 && '<' !== $content[0] ) {
                 $content = preg_replace_callback( $wp_smiliessearch, 'translate_smiley', $content );
             }
 
             // Did we exit ignore block?
-            if ( '' != $ignore_block_element && '</' . $ignore_block_element . '>' == $content ) {
+            if ( '' !== $ignore_block_element && '</' . $ignore_block_element . '>' === $content ) {
                 $ignore_block_element = '';
             }
@@ -3574 +3574 @@
         $offset = 0;
     } else {
-        $sign    = ( substr( $timezone, 0, 1 ) == '+' ) ? 1 : -1;
+        $sign    = ( '+' === substr( $timezone, 0, 1 ) ) ? 1 : -1;
         $hours   = intval( substr( $timezone, 1, 2 ) );
         $minutes = intval( substr( $timezone, 3, 4 ) ) / 60;
@@ -3814 +3814 @@
 function wp_trim_excerpt( $text = '', $post = null ) {
     $raw_excerpt = $text;
-    if ( '' == $text ) {
+
+    if ( '' === $text ) {
         $post = get_post( $post );
         $text = get_the_content( '', false, $post );
@@ -4308 +4309 @@
     $original_url = $url;
 
-    if ( '' == $url ) {
+    if ( '' === $url ) {
         return $url;
     }
@@ -4336 +4337 @@
 
     // Replace ampersands and single quotes only when displaying.
-    if ( 'display' == $_context ) {
+    if ( 'display' === $_context ) {
         $url = wp_kses_normalize_entities( $url );
         $url = str_replace( '&amp;', '&#038;', $url );
@@ -4646 +4647 @@
         case 'default_comment_status':
             // Options that if not there have 0 value but need to be something like "closed".
-            if ( '0' == $value || '' == $value ) {
+            if ( '0' == $value || '' === $value ) {
                 $value = 'closed';
             }
@@ -4978 +4979 @@
 
         // Literal %: append and continue.
-        if ( substr( $pattern, $start, 2 ) == '%%' ) {
+        if ( '%%' === substr( $pattern, $start, 2 ) ) {
             $start  += 2;
             $result .= '%';
@@ -5044 +5045 @@
 function wp_sprintf_l( $pattern, $args ) {
     // Not a match.
-    if ( substr( $pattern, 0, 2 ) != '%l' ) {
+    if ( '%l' !== substr( $pattern, 0, 2 ) ) {
         return $pattern;
     }
@@ -5807 +5808 @@
 
         // If we're in an ignore block, wait until we find its closing tag.
-        if ( '' == $ignore_block_element && preg_match( '/^<(' . $tags_to_ignore . ')>/', $content, $matches ) ) {
+        if ( '' === $ignore_block_element && preg_match( '/^<(' . $tags_to_ignore . ')>/', $content, $matches ) ) {
             $ignore_block_element = $matches[1];
         }
 
         // If it's not a tag and not in ignore block.
-        if ( '' == $ignore_block_element && strlen( $content ) > 0 && '<' != $content[0] && false !== strpos( $content, '&#x' ) ) {
+        if ( '' === $ignore_block_element && strlen( $content ) > 0 && '<' !== $content[0] && false !== strpos( $content, '&#x' ) ) {
             foreach ( $possible_emoji as $emojum => $emoji_char ) {
                 if ( false === strpos( $content, $emojum ) ) {
@@ -5828 +5829 @@
 
         // Did we exit ignore block?
-        if ( '' != $ignore_block_element && '</' . $ignore_block_element . '>' == $content ) {
+        if ( '' !== $ignore_block_element && '</' . $ignore_block_element . '>' === $content ) {
             $ignore_block_element = '';
         }