Changeset 47808 for trunk/src/wp-includes/general-template.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/general-template.php (modified) (14 diffs)

trunk/src/wp-includes/general-template.php

@@ -254 +254 @@
 
     $search_form_template = locate_template( 'searchform.php' );
-    if ( '' != $search_form_template ) {
+
+    if ( '' !== $search_form_template ) {
         ob_start();
         require $search_form_template;
@@ -269 +270 @@
             $aria_label = '';
         }
-        if ( 'html5' == $format ) {
+        if ( 'html5' === $format ) {
             $form = '<form role="search" ' . $aria_label . 'method="get" class="search-form" action="' . esc_url( home_url( '/' ) ) . '">
                 <label>
@@ -763 +764 @@
         case 'charset':
             $output = get_option( 'blog_charset' );
-            if ( '' == $output ) {
+            if ( '' === $output ) {
                 $output = 'UTF-8';
             }
@@ -817 +818 @@
     }
 
-    if ( 'display' == $filter ) {
+    if ( 'display' === $filter ) {
         if ( $url ) {
             /**
@@ -1287 +1288 @@
 
     // Determines position of the separator and direction of the breadcrumb.
-    if ( 'right' == $seplocation ) { // Separator on right, so reverse the order.
+    if ( 'right' === $seplocation ) { // Separator on right, so reverse the order.
         $title_array = array_reverse( $title_array );
         $title       = implode( " $sep ", $title_array ) . $prefix;
@@ -1835 +1836 @@
         return;
     }
+
     $parsed_args['post_type'] = $post_type_object->name;
 
-    if ( '' == $parsed_args['type'] ) {
+    if ( '' === $parsed_args['type'] ) {
         $parsed_args['type'] = 'monthly';
     }
@@ -1882 +1884 @@
     $limit = $parsed_args['limit'];
 
-    if ( 'monthly' == $parsed_args['type'] ) {
+    if ( 'monthly' === $parsed_args['type'] ) {
         $query   = "SELECT YEAR(post_date) AS `year`, MONTH(post_date) AS `month`, count(ID) as posts FROM $wpdb->posts $join $where GROUP BY YEAR(post_date), MONTH(post_date) ORDER BY post_date $order $limit";
         $key     = md5( $query );
@@ -1907 +1909 @@
             }
         }
-    } elseif ( 'yearly' == $parsed_args['type'] ) {
+    } elseif ( 'yearly' === $parsed_args['type'] ) {
         $query   = "SELECT YEAR(post_date) AS `year`, count(ID) as posts FROM $wpdb->posts $join $where GROUP BY YEAR(post_date) ORDER BY post_date $order $limit";
         $key     = md5( $query );
@@ -1931 +1933 @@
             }
         }
-    } elseif ( 'daily' == $parsed_args['type'] ) {
+    } elseif ( 'daily' === $parsed_args['type'] ) {
         $query   = "SELECT YEAR(post_date) AS `year`, MONTH(post_date) AS `month`, DAYOFMONTH(post_date) AS `dayofmonth`, count(ID) as posts FROM $wpdb->posts $join $where GROUP BY YEAR(post_date), MONTH(post_date), DAYOFMONTH(post_date) ORDER BY post_date $order $limit";
         $key     = md5( $query );
@@ -1956 +1958 @@
             }
         }
-    } elseif ( 'weekly' == $parsed_args['type'] ) {
+    } elseif ( 'weekly' === $parsed_args['type'] ) {
         $week    = _wp_mysql_week( '`post_date`' );
         $query   = "SELECT DISTINCT $week AS `week`, YEAR( `post_date` ) AS `yr`, DATE_FORMAT( `post_date`, '%Y-%m-%d' ) AS `yyyymmdd`, count( `ID` ) AS `posts` FROM `$wpdb->posts` $join $where GROUP BY $week, YEAR( `post_date` ) ORDER BY `post_date` $order $limit";
@@ -1995 +1997 @@
             }
         }
-    } elseif ( ( 'postbypost' == $parsed_args['type'] ) || ( 'alpha' == $parsed_args['type'] ) ) {
-        $orderby = ( 'alpha' == $parsed_args['type'] ) ? 'post_title ASC ' : 'post_date DESC, ID DESC ';
+    } elseif ( ( 'postbypost' === $parsed_args['type'] ) || ( 'alpha' === $parsed_args['type'] ) ) {
+        $orderby = ( 'alpha' === $parsed_args['type'] ) ? 'post_title ASC ' : 'post_date DESC, ID DESC ';
         $query   = "SELECT * FROM $wpdb->posts $join $where ORDER BY $orderby $limit";
         $key     = md5( $query );
@@ -2403 +2405 @@
     }
 
-    if ( '' == $format ) {
+    if ( '' === $format ) {
         $the_date = get_post_time( get_option( 'date_format' ), false, $post, true );
     } else {
@@ -2532 +2534 @@
     }
 
-    if ( '' == $format ) {
+    if ( '' === $format ) {
         $the_time = get_post_time( get_option( 'time_format' ), false, $post, true );
     } else {
@@ -3343 +3345 @@
         $wp_rich_edit = false;
 
-        if ( get_user_option( 'rich_editing' ) == 'true' || ! is_user_logged_in() ) { // Default to 'true' for logged out users.
+        if ( 'true' === get_user_option( 'rich_editing' ) || ! is_user_logged_in() ) { // Default to 'true' for logged out users.
             if ( $is_safari ) {
                 $wp_rich_edit = ! wp_is_mobile() || ( preg_match( '!AppleWebKit/(\d+)!', $_SERVER['HTTP_USER_AGENT'], $match ) && intval( $match[1] ) >= 534 );