Changeset 47808 for trunk/src/wp-includes/kses.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/kses.php (modified) (9 diffs)

trunk/src/wp-includes/kses.php

@@ -776 +776 @@
                 // Remove quotes surrounding $value.
                 // Also guarantee correct quoting in $string for this one attribute.
-                if ( '' == $value ) {
+                if ( '' === $value ) {
                         $quote = '';
                 } else {
                         $quote = $value[0];
                 }
-                if ( '"' == $quote || "'" == $quote ) {
+                if ( '"' === $quote || "'" === $quote ) {
                         if ( substr( $value, -1 ) != $quote ) {
                                 return '';
@@ -1040 +1040 @@
 
         // It matched a ">" character.
-        if ( substr( $string, 0, 1 ) != '<' ) {
+        if ( '<' !== substr( $string, 0, 1 ) ) {
                 return '&gt;';
         }
 
         // Allow HTML comments.
-        if ( '<!--' == substr( $string, 0, 4 ) ) {
+        if ( '<!--' === substr( $string, 0, 4 ) ) {
                 $string = str_replace( array( '<!--', '-->' ), '', $string );
                 while ( ( $newstring = wp_kses( $string, $allowed_html, $allowed_protocols ) ) != $string ) {
                         $string = $newstring;
                 }
-                if ( '' == $string ) {
+                if ( '' === $string ) {
                         return '';
                 }
@@ -1079 +1079 @@
 
         // No attributes are allowed for closing elements.
-        if ( '' != $slash ) {
+        if ( '' !== $slash ) {
                 return "</$elem>";
         }
@@ -1165 +1165 @@
         $allowed_attr = $allowed_html[ $element_low ];
 
-        if ( ! isset( $allowed_attr[ $name_low ] ) || '' == $allowed_attr[ $name_low ] ) {
+        if ( ! isset( $allowed_attr[ $name_low ] ) || '' === $allowed_attr[ $name_low ] ) {
                 /*
                  * Allow `data-*` attributes.
@@ -1190 +1190 @@
         }
 
-        if ( 'style' == $name_low ) {
+        if ( 'style' === $name_low ) {
                 $new_value = safecss_filter_attr( $value );
 
@@ -1610 +1610 @@
 
         $string = preg_replace( '/[\x00-\x08\x0B\x0C\x0E-\x1F]/', '', $string );
-        if ( 'remove' == $options['slash_zero'] ) {
+        if ( 'remove' === $options['slash_zero'] ) {
                 $string = preg_replace( '/\\\\+0+/', '', $string );
         }
@@ -1689 +1689 @@
                 $string   = trim( $string2[1] );
                 $protocol = wp_kses_bad_protocol_once2( $string2[0], $allowed_protocols );
-                if ( 'feed:' == $protocol ) {
+                if ( 'feed:' === $protocol ) {
                         if ( $count > 2 ) {
                                 return '';
@@ -2245 +2245 @@
         $css = '';
         foreach ( $css_array as $css_item ) {
-                if ( '' == $css_item ) {
+                if ( '' === $css_item ) {
                         continue;
                 }
@@ -2303 +2303 @@
                 // Remove any CSS containing containing \ ( & } = or comments, except for url() useage checked above.
                 if ( $found && ! preg_match( '%[\\\(&=}]|/\*%', $css_test_string ) ) {
-                        if ( '' != $css ) {
+                        if ( '' !== $css ) {
                                 $css .= ';';
                         }