Changeset 47808 for trunk/src/wp-includes/link-template.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/link-template.php (modified) (19 diffs)

trunk/src/wp-includes/link-template.php

@@ -132 +132 @@
     );
 
-    if ( is_object( $post ) && isset( $post->filter ) && 'sample' == $post->filter ) {
+    if ( is_object( $post ) && isset( $post->filter ) && 'sample' === $post->filter ) {
         $sample = true;
     } else {
@@ -166 +166 @@
     $permalink = apply_filters( 'pre_post_link', $permalink, $post, $leavename );
 
-    if ( '' != $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ), true ) ) {
+    if ( $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ), true ) ) {
 
         $category = '';
@@ -621 +621 @@
 
     $permalink = $wp_rewrite->get_feed_permastruct();
-    if ( '' != $permalink ) {
+
+    if ( '' !== $permalink ) {
         if ( false !== strpos( $feed, 'comments_' ) ) {
             $feed      = str_replace( 'comments_', '', $feed );
@@ -682 +683 @@
     $unattached = 'attachment' === $post->post_type && 0 === (int) $post->post_parent;
 
-    if ( '' != get_option( 'permalink_structure' ) ) {
+    if ( get_option( 'permalink_structure' ) ) {
         if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post_id ) {
             $url = _get_page_link( $post_id );
@@ -795 +796 @@
     }
 
-    if ( '' == $permalink_structure ) {
+    if ( ! $permalink_structure ) {
         $link = home_url( "?feed=$feed&author=" . $author_id );
     } else {
@@ -867 +868 @@
     $permalink_structure = get_option( 'permalink_structure' );
 
-    if ( '' == $permalink_structure ) {
-        if ( 'category' == $taxonomy ) {
+    if ( ! $permalink_structure ) {
+        if ( 'category' === $taxonomy ) {
             $link = home_url( "?feed=$feed&cat=$term_id" );
-        } elseif ( 'post_tag' == $taxonomy ) {
+        } elseif ( 'post_tag' === $taxonomy ) {
             $link = home_url( "?feed=$feed&tag=$term->slug" );
         } else {
@@ -887 +888 @@
     }
 
-    if ( 'category' == $taxonomy ) {
+    if ( 'category' === $taxonomy ) {
         /**
          * Filters the category feed link.
@@ -897 +898 @@
          */
         $link = apply_filters( 'category_feed_link', $link, $feed );
-    } elseif ( 'post_tag' == $taxonomy ) {
+    } elseif ( 'post_tag' === $taxonomy ) {
         /**
          * Filters the post tag feed link.
@@ -1365 +1366 @@
     if ( 'revision' === $post->post_type ) {
         $action = '';
-    } elseif ( 'display' == $context ) {
+    } elseif ( 'display' === $context ) {
         $action = '&action=edit';
     } else {
@@ -2269 +2270 @@
         $base = trailingslashit( get_bloginfo( 'url' ) );
 
-        if ( $wp_rewrite->using_index_permalinks() && ( $pagenum > 1 || '' != $request ) ) {
+        if ( $wp_rewrite->using_index_permalinks() && ( $pagenum > 1 || '' !== $request ) ) {
             $base .= $wp_rewrite->index . '/';
         }
@@ -2729 +2730 @@
 
         // Make sure we get a string back. Plain is the next best thing.
-        if ( isset( $args['type'] ) && 'array' == $args['type'] ) {
+        if ( isset( $args['type'] ) && 'array' === $args['type'] ) {
             $args['type'] = 'plain';
         }
@@ -2824 +2825 @@
     $result = get_permalink();
 
-    if ( 'newest' == get_option( 'default_comments_page' ) ) {
+    if ( 'newest' === get_option( 'default_comments_page' ) ) {
         if ( $pagenum != $max_page ) {
             if ( $wp_rewrite->using_permalinks() ) {
@@ -3111 +3112 @@
 
     // Make sure we get a string back. Plain is the next best thing.
-    if ( isset( $args['type'] ) && 'array' == $args['type'] ) {
+    if ( isset( $args['type'] ) && 'array' === $args['type'] ) {
         $args['type'] = 'plain';
     }
@@ -3406 +3407 @@
     if ( ! empty( $plugin ) && is_string( $plugin ) ) {
         $folder = dirname( plugin_basename( $plugin ) );
-        if ( '.' != $folder ) {
+        if ( '.' !== $folder ) {
             $url .= '/' . ltrim( $folder, '/' );
         }
@@ -3452 +3453 @@
     $current_network = get_network();
 
-    if ( 'relative' == $scheme ) {
+    if ( 'relative' === $scheme ) {
         $url = $current_network->path;
     } else {
@@ -3502 +3503 @@
     }
 
-    if ( 'relative' == $scheme ) {
+    if ( 'relative' === $scheme ) {
         $url = $current_network->path;
     } else {
@@ -3646 +3647 @@
     }
 
-    if ( 'relative' == $scheme ) {
+    if ( 'relative' === $scheme ) {
         $url = ltrim( preg_replace( '#^\w+://[^/]*#', '', $url ) );
         if ( '' !== $url && '/' === $url[0] ) {
@@ -3785 +3786 @@
         $page = get_query_var( 'page', 0 );
         if ( $page >= 2 ) {
-            if ( '' == get_option( 'permalink_structure' ) ) {
+            if ( ! get_option( 'permalink_structure' ) ) {
                 $canonical_url = add_query_arg( 'page', $page, $canonical_url );
             } else {
@@ -3874 +3875 @@
 
     $post_id = 0;
-    if ( 'query' == $context && is_singular() ) {
+    if ( 'query' === $context && is_singular() ) {
         $post_id = get_queried_object_id();
         $post    = get_post( $post_id );
-    } elseif ( 'post' == $context ) {
+    } elseif ( 'post' === $context ) {
         $post = get_post( $id );
         if ( ! empty( $post->ID ) ) {