Changeset 47808 for trunk/src/wp-includes/load.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/load.php (modified) (6 diffs)

trunk/src/wp-includes/load.php

@@ -41 +41 @@
 
     // Fix for IIS when running with PHP ISAPI.
-    if ( empty( $_SERVER['REQUEST_URI'] ) || ( PHP_SAPI != 'cgi-fcgi' && preg_match( '/^Microsoft-IIS\//', $_SERVER['SERVER_SOFTWARE'] ) ) ) {
+    if ( empty( $_SERVER['REQUEST_URI'] ) || ( 'cgi-fcgi' !== PHP_SAPI && preg_match( '/^Microsoft-IIS\//', $_SERVER['SERVER_SOFTWARE'] ) ) ) {
 
         if ( isset( $_SERVER['HTTP_X_ORIGINAL_URL'] ) ) {
@@ -138 +138 @@
  */
 function wp_favicon_request() {
-    if ( '/favicon.ico' == $_SERVER['REQUEST_URI'] ) {
+    if ( '/favicon.ico' === $_SERVER['REQUEST_URI'] ) {
         header( 'Content-Type: image/vnd.microsoft.icon' );
         exit;
@@ -629 +629 @@
     }
     while ( ( $plugin = readdir( $dh ) ) !== false ) {
-        if ( substr( $plugin, -4 ) == '.php' ) {
+        if ( '.php' === substr( $plugin, -4 ) ) {
             $mu_plugins[] = WPMU_PLUGIN_DIR . '/' . $plugin;
         }
@@ -671 +671 @@
     foreach ( $active_plugins as $plugin ) {
         if ( ! validate_file( $plugin )                     // $plugin must validate as file.
-            && '.php' == substr( $plugin, -4 )              // $plugin must end with '.php'.
+            && '.php' === substr( $plugin, -4 )             // $plugin must end with '.php'.
             && file_exists( WP_PLUGIN_DIR . '/' . $plugin ) // $plugin must exist.
             // Not already included as a network plugin.
@@ -1169 +1169 @@
     while ( true ) {
         if ( defined( 'WPLANG' ) ) {
-            if ( '' == WPLANG ) {
+            if ( '' === WPLANG ) {
                 break;
             }
@@ -1264 +1264 @@
 function is_ssl() {
     if ( isset( $_SERVER['HTTPS'] ) ) {
-        if ( 'on' == strtolower( $_SERVER['HTTPS'] ) ) {
+        if ( 'on' === strtolower( $_SERVER['HTTPS'] ) ) {
             return true;
         }