Changeset 47808 for trunk/src/wp-includes/nav-menu-template.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/nav-menu-template.php (modified) (9 diffs)

trunk/src/wp-includes/nav-menu-template.php

@@ -393 +393 @@
 
                 // If the menu item corresponds to a taxonomy term for the currently queried non-hierarchical post object.
-                if ( $wp_query->is_singular && 'taxonomy' == $menu_item->type
+                if ( $wp_query->is_singular && 'taxonomy' === $menu_item->type
                         && in_array( (int) $menu_item->object_id, $possible_object_parents, true )
                 ) {
@@ -404 +404 @@
                         $menu_item->object_id == $queried_object_id
                         && (
-                                ( ! empty( $home_page_id ) && 'post_type' == $menu_item->type && $wp_query->is_home && $home_page_id == $menu_item->object_id )
-                                || ( 'post_type' == $menu_item->type && $wp_query->is_singular )
-                                || ( 'taxonomy' == $menu_item->type
+                                ( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
+                                        && $wp_query->is_home && $home_page_id == $menu_item->object_id )
+                                || ( 'post_type' === $menu_item->type && $wp_query->is_singular )
+                                || ( 'taxonomy' === $menu_item->type
                                         && ( $wp_query->is_category || $wp_query->is_tag || $wp_query->is_tax )
                                         && $queried_object->taxonomy == $menu_item->object )
@@ -422 +423 @@
                         }
 
-                        if ( 'post_type' == $menu_item->type && 'page' == $menu_item->object ) {
+                        if ( 'post_type' === $menu_item->type && 'page' === $menu_item->object ) {
                                 // Back compat classes for pages to match wp_page_menu().
                                 $classes[] = 'page_item';
@@ -435 +436 @@
                         // If the menu item corresponds to the currently queried post type archive.
                 } elseif (
-                        'post_type_archive' == $menu_item->type
+                        'post_type_archive' === $menu_item->type
                         && is_post_type_archive( array( $menu_item->object ) )
                 ) {
@@ -452 +453 @@
 
                         // If the menu item corresponds to the currently requested URL.
-                } elseif ( 'custom' == $menu_item->object && isset( $_SERVER['HTTP_HOST'] ) ) {
+                } elseif ( 'custom' === $menu_item->object && isset( $_SERVER['HTTP_HOST'] ) ) {
                         $_root_relative_current = untrailingslashit( $_SERVER['REQUEST_URI'] );
 
@@ -505 +506 @@
 
                 // Back-compat with wp_page_menu(): add "current_page_parent" to static home page link for any non-page query.
-                if ( ! empty( $home_page_id ) && 'post_type' == $menu_item->type && empty( $wp_query->is_page ) && $home_page_id == $menu_item->object_id ) {
+                if ( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
+                        && empty( $wp_query->is_page ) && $home_page_id == $menu_item->object_id
+                ) {
                         $classes[] = 'current_page_parent';
                 }
@@ -526 +529 @@
                                 // Ancestral post object.
                                 (
-                                        'post_type' == $parent_item->type
+                                        'post_type' === $parent_item->type
                                         && ! empty( $queried_object->post_type )
                                         && is_post_type_hierarchical( $queried_object->post_type )
@@ -535 +538 @@
                                 // Ancestral term.
                                 (
-                                        'taxonomy' == $parent_item->type
+                                        'taxonomy' === $parent_item->type
                                         && isset( $possible_taxonomy_ancestors[ $parent_item->object ] )
                                         && in_array( (int) $parent_item->object_id, $possible_taxonomy_ancestors[ $parent_item->object ], true )
@@ -566 +569 @@
                 }
 
-                if ( 'post_type' == $parent_item->type && 'page' == $parent_item->object ) {
+                if ( 'post_type' === $parent_item->type && 'page' === $parent_item->object ) {
                         // Back compat classes for pages to match wp_page_menu().
                         if ( in_array( 'current-menu-parent', $classes, true ) ) {