Changeset 47808 for trunk/src/wp-includes/pluggable.php

Timestamp:

05/16/2020 06:40:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/pluggable.php (modified) (8 diffs)

trunk/src/wp-includes/pluggable.php

@@ -330 +330 @@
             // Get the site domain and get rid of www.
             $sitename = strtolower( $_SERVER['SERVER_NAME'] );
-            if ( substr( $sitename, 0, 4 ) == 'www.' ) {
+            if ( 'www.' === substr( $sitename, 0, 4 ) ) {
                 $sitename = substr( $sitename, 4 );
             }
@@ -433 +433 @@
 
         // Set whether it's plaintext, depending on $content_type.
-        if ( 'text/html' == $content_type ) {
+        if ( 'text/html' === $content_type ) {
             $phpmailer->isHTML( true );
         }
@@ -634 +634 @@
 
         // Allow a grace period for POST and Ajax requests.
-        if ( wp_doing_ajax() || 'POST' == $_SERVER['REQUEST_METHOD'] ) {
+        if ( wp_doing_ajax() || 'POST' === $_SERVER['REQUEST_METHOD'] ) {
             $expired += HOUR_IN_SECONDS;
         }
@@ -1267 +1267 @@
         $location = wp_sanitize_redirect( $location );
 
-        if ( ! $is_IIS && PHP_SAPI != 'cgi-fcgi' ) {
+        if ( ! $is_IIS && 'cgi-fcgi' !== PHP_SAPI ) {
             status_header( $status ); // This causes problems on IIS and some FastCGI setups.
         }
@@ -1415 +1415 @@
         $location = trim( $location, " \t\n\r\0\x08\x0B" );
         // Browsers will assume 'http' is your protocol, and will obey a redirect to a URL starting with '//'.
-        if ( substr( $location, 0, 2 ) == '//' ) {
+        if ( '//' === substr( $location, 0, 2 ) ) {
             $location = 'http:' . $location;
         }
@@ -1432 +1432 @@
 
         // Allow only 'http' and 'https' schemes. No 'data:', etc.
-        if ( isset( $lp['scheme'] ) && ! ( 'http' == $lp['scheme'] || 'https' == $lp['scheme'] ) ) {
+        if ( isset( $lp['scheme'] ) && ! ( 'http' === $lp['scheme'] || 'https' === $lp['scheme'] ) ) {
             return $default;
         }
@@ -1647 +1647 @@
         $wp_email = 'wordpress@' . preg_replace( '#^www\.#', '', strtolower( $_SERVER['SERVER_NAME'] ) );
 
-        if ( '' == $comment->comment_author ) {
+        if ( '' === $comment->comment_author ) {
             $from = "From: \"$blogname\" <$wp_email>";
-            if ( '' != $comment->comment_author_email ) {
+            if ( '' !== $comment->comment_author_email ) {
                 $reply_to = "Reply-To: $comment->comment_author_email";
             }
         } else {
             $from = "From: \"$comment->comment_author\" <$wp_email>";
-            if ( '' != $comment->comment_author_email ) {
+            if ( '' !== $comment->comment_author_email ) {
                 $reply_to = "Reply-To: \"$comment->comment_author_email\" <$comment->comment_author_email>";
             }
@@ -2272 +2272 @@
             $values['key'] = SECRET_KEY;
         }
-        if ( 'auth' == $scheme && defined( 'SECRET_SALT' ) && SECRET_SALT && empty( $duplicated_keys[ SECRET_SALT ] ) ) {
+        if ( 'auth' === $scheme && defined( 'SECRET_SALT' ) && SECRET_SALT && empty( $duplicated_keys[ SECRET_SALT ] ) ) {
             $values['salt'] = SECRET_SALT;
         }