Changeset 47808 for trunk/src/wp-includes/pomo/po.php

Timestamp:

05/16/2020 06:40:52 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/pomo/po.php (modified) (5 diffs)

trunk/src/wp-includes/pomo/po.php

@@ -150 +150 @@
                                 foreach ( $chars as $char ) {
                                         if ( ! $previous_is_backslash ) {
-                                                if ( '\\' == $char ) {
+                                                if ( '\\' === $char ) {
                                                         $previous_is_backslash = true;
                                                 } else {
@@ -295 +295 @@
                                         break;
                                 }
-                                if ( '' == $res['entry']->singular ) {
+                                if ( '' === $res['entry']->singular ) {
                                         $this->set_headers( $this->make_headers( $res['entry']->translations[0] ) );
                                 } else {
@@ -461 +461 @@
                         static $last_line     = '';
                         static $use_last_line = false;
-                        if ( 'clear' == $action ) {
+                        if ( 'clear' === $action ) {
                                 $last_line = '';
                                 return true;
                         }
-                        if ( 'put-back' == $action ) {
+                        if ( 'put-back' === $action ) {
                                 $use_last_line = true;
                                 return true;
                         }
                         $line          = $use_last_line ? $last_line : fgets( $f );
-                        $line          = ( "\r\n" == substr( $line, -2 ) ) ? rtrim( $line, "\r\n" ) . "\n" : $line;
+                        $line          = ( "\r\n" === substr( $line, -2 ) ) ? rtrim( $line, "\r\n" ) . "\n" : $line;
                         $last_line     = $line;
                         $use_last_line = false;
@@ -483 +483 @@
                         $first_two = substr( $po_comment_line, 0, 2 );
                         $comment   = trim( substr( $po_comment_line, 2 ) );
-                        if ( '#:' == $first_two ) {
+                        if ( '#:' === $first_two ) {
                                 $entry->references = array_merge( $entry->references, preg_split( '/\s+/', $comment ) );
-                        } elseif ( '#.' == $first_two ) {
+                        } elseif ( '#.' === $first_two ) {
                                 $entry->extracted_comments = trim( $entry->extracted_comments . "\n" . $comment );
-                        } elseif ( '#,' == $first_two ) {
+                        } elseif ( '#,' === $first_two ) {
                                 $entry->flags = array_merge( $entry->flags, preg_split( '/,\s*/', $comment ) );
                         } else {
@@ -499 +499 @@
                  */
                 public static function trim_quotes( $s ) {
-                        if ( substr( $s, 0, 1 ) == '"' ) {
+                        if ( '"' === substr( $s, 0, 1 ) ) {
                                 $s = substr( $s, 1 );
                         }
-                        if ( substr( $s, -1, 1 ) == '"' ) {
+                        if ( '"' === substr( $s, -1, 1 ) ) {
                                 $s = substr( $s, 0, -1 );
                         }