Changeset 47808 for trunk/src/wp-includes/theme.php

Timestamp:

05/16/2020 06:40:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where static strings are involved.

This reduces the number of WordPress.PHP.StrictComparisons.LooseComparison issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/theme.php (modified) (9 diffs)

trunk/src/wp-includes/theme.php

@@ -1157 +1157 @@
     $url = get_theme_mod( 'header_image', get_theme_support( 'custom-header', 'default-image' ) );
 
-    if ( 'remove-header' == $url ) {
+    if ( 'remove-header' === $url ) {
         return false;
     }
@@ -1266 +1266 @@
         $headers          = array();
 
-        if ( 'random-uploaded-image' == $header_image_mod ) {
+        if ( 'random-uploaded-image' === $header_image_mod ) {
             $headers = get_uploaded_header_images();
         } elseif ( ! empty( $_wp_default_headers ) ) {
-            if ( 'random-default-image' == $header_image_mod ) {
+            if ( 'random-default-image' === $header_image_mod ) {
                 $headers = $_wp_default_headers;
             } else {
@@ -1287 +1287 @@
         $_wp_random_header->thumbnail_url = sprintf( $_wp_random_header->thumbnail_url, get_template_directory_uri(), get_stylesheet_directory_uri() );
     }
+
     return $_wp_random_header;
 }
@@ -1299 +1300 @@
 function get_random_header_image() {
     $random_image = _get_random_header_data();
+
     if ( empty( $random_image->url ) ) {
         return '';
     }
+
     return $random_image->url;
 }
@@ -1320 +1323 @@
     $header_image_mod = get_theme_mod( 'header_image', get_theme_support( 'custom-header', 'default-image' ) );
 
-    if ( 'any' == $type ) {
-        if ( 'random-default-image' == $header_image_mod || 'random-uploaded-image' == $header_image_mod || ( '' != get_random_header_image() && empty( $header_image_mod ) ) ) {
+    if ( 'any' === $type ) {
+        if ( 'random-default-image' === $header_image_mod
+            || 'random-uploaded-image' === $header_image_mod
+            || ( '' !== get_random_header_image() && empty( $header_image_mod ) )
+        ) {
             return true;
         }
     } else {
-        if ( "random-$type-image" == $header_image_mod ) {
+        if ( "random-$type-image" === $header_image_mod ) {
             return true;
-        } elseif ( 'default' == $type && empty( $header_image_mod ) && '' != get_random_header_image() ) {
+        } elseif ( 'default' === $type && empty( $header_image_mod ) && '' !== get_random_header_image() ) {
             return true;
         }
@@ -1342 +1348 @@
 function header_image() {
     $image = get_header_image();
+
     if ( $image ) {
         echo esc_url( $image );
@@ -1537 +1544 @@
 function the_header_video_url() {
     $video = get_header_video_url();
+
     if ( $video ) {
         echo esc_url( $video );
@@ -2904 +2912 @@
     global $_wp_theme_features;
 
-    if ( 'custom-header-uploads' == $feature ) {
+    if ( 'custom-header-uploads' === $feature ) {
         return current_theme_supports( 'custom-header', 'uploads' );
     }
@@ -3075 +3083 @@
 function _wp_customize_include() {
 
-    $is_customize_admin_page = ( is_admin() && 'customize.php' == basename( $_SERVER['PHP_SELF'] ) );
+    $is_customize_admin_page = ( is_admin() && 'customize.php' === basename( $_SERVER['PHP_SELF'] ) );
     $should_include          = (
         $is_customize_admin_page
         ||
-        ( isset( $_REQUEST['wp_customize'] ) && 'on' == $_REQUEST['wp_customize'] )
+        ( isset( $_REQUEST['wp_customize'] ) && 'on' === $_REQUEST['wp_customize'] )
         ||
         ( ! empty( $_GET['customize_changeset_uuid'] ) || ! empty( $_POST['customize_changeset_uuid'] ) )