Changeset 47814

Timestamp:

05/17/2020 09:37:12 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Fix WPCS issues in plugin and theme upgrader classes.

See #49542.

Location:

trunk/src/wp-admin/includes

Files:

• class-plugin-upgrader.php (modified) (1 diff)
• class-theme-upgrader-skin.php (modified) (1 diff)
• class-theme-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -554 +554 @@
         // If plugin is in its own directory, recursively delete the directory.
         // Base check on if plugin includes directory separator AND that it's not the root plugin folder.
-        if ( strpos( $plugin, '/' ) && $this_plugin_dir != $plugins_dir ) {
+        if ( strpos( $plugin, '/' ) && $this_plugin_dir !== $plugins_dir ) {
             $deleted = $wp_filesystem->delete( $this_plugin_dir, true );
         } else {

trunk/src/wp-admin/includes/class-theme-upgrader-skin.php

@@ -66 +66 @@
             );
 
-            if ( get_stylesheet() == $stylesheet ) {
+            if ( get_stylesheet() === $stylesheet ) {
                 if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
                     $update_actions['preview'] = sprintf(

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -578 +578 @@
 
         // Ensure stylesheet name hasn't changed after the upgrade:
-        if ( get_stylesheet() === $theme && $theme != $this->result['destination_name'] ) {
+        if ( get_stylesheet() === $theme && $theme !== $this->result['destination_name'] ) {
             wp_clean_themes_cache();
             $stylesheet = $this->result['destination_name'];