Changeset 47842 for trunk/tests/phpunit/tests/rest-api.php

Timestamp:

05/22/2020 08:46:03 PM (6 years ago)

Author:

whyisjake

Message:

REST API: Ensure proper namespacing when registering routes.

The PR will corerce routes that have a leading slash and throwing a _doing_it_wrong notice while ensuring a proper namespace.

Fixes #49749.
Props TimothyBlynJacobs, skarabeq, afercia.

File:

• trunk/tests/phpunit/tests/rest-api.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api.php

@@ -984 +984 @@
         public function test_rest_filter_response_by_context( $schema, $data, $expected ) {
                 $this->assertEquals( $expected, rest_filter_response_by_context( $data, $schema, 'view' ) );
+        }
+
+        /**
+         * @ticket 49749
+         */
+        public function test_register_route_with_invalid_namespace() {
+                $this->setExpectedIncorrectUsage( 'register_rest_route' );
+
+                register_rest_route(
+                        '/my-namespace/v1/',
+                        '/my-route',
+                        array(
+                                'callback' => '__return_true',
+                        )
+                );
+
+                $routes = rest_get_server()->get_routes( 'my-namespace/v1' );
+                $this->assertCount( 2, $routes );
+
+                $this->assertTrue( rest_do_request( '/my-namespace/v1/my-route' )->get_data() );
         }