Changeset 47880

Timestamp:

06/01/2020 07:41:50 PM (5 years ago)

Author:

ocean90

Message:

Build/Test Tools: Let WP_UnitTestCase_Base extend the namespaced version of PHPUnit's test case class.

With the minimum PHP version requirement set to 5.6 we're now able to use namespaces by default. This replaces PHPUnit_Framework_TestCase with PHPUnit\Framework\TestCase for WP_UnitTestCase_Base to solve autocompletion issues with code editors when using more recent PHPUnit versions. PHPUnit\Framework\TestCase is available since PHPUnit 5.4 and now the minimum required PHPUnit version.

Fixes #50236.

Location:

trunk/tests/phpunit/includes

Files:

• abstract-testcase.php (modified) (1 diff)
• bootstrap.php (modified) (1 diff)
• functions.php (modified) (1 diff)

trunk/tests/phpunit/includes/abstract-testcase.php

@@ -13 +13 @@
  * All WordPress unit tests should inherit from this class.
  */
-abstract class WP_UnitTestCase_Base extends PHPUnit_Framework_TestCase {
+abstract class WP_UnitTestCase_Base extends PHPUnit\Framework\TestCase {
 
     protected static $forced_tickets   = array();

trunk/tests/phpunit/includes/bootstrap.php

@@ -38 +38 @@
 require_once __DIR__ . '/functions.php';
 
-if ( version_compare( tests_get_phpunit_version(), '8.0', '>=' ) ) {
+if ( version_compare( tests_get_phpunit_version(), '5.4', '<' ) || version_compare( tests_get_phpunit_version(), '8.0', '>=' ) ) {
     printf(
-        "Error: Looks like you're using PHPUnit %s. WordPress is currently only compatible with PHPUnit up to 7.x.\n",
+        "Error: Looks like you're using PHPUnit %s. WordPress requires at least PHPUnit 5.4 and is currently only compatible with PHPUnit up to 7.x.\n",
         tests_get_phpunit_version()
     );

trunk/tests/phpunit/includes/functions.php

@@ -11 +11 @@
         $version = PHPUnit_Runner_Version::id();
     } elseif ( class_exists( 'PHPUnit\Runner\Version' ) ) {
-        // Must be parsable by PHP 5.2.x.
-        $version = call_user_func( 'PHPUnit\Runner\Version::id' );
+        $version = PHPUnit\Runner\Version::id();
     } else {
         $version = 0;