Changeset 47886 for trunk/src/wp-content/themes/twentytwelve/functions.php

Timestamp:

06/02/2020 05:03:06 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Bundled Themes: Consistently check for WP_Error before outputting get_the_tag_list().

Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.

File:

• trunk/src/wp-content/themes/twentytwelve/functions.php (modified) (3 diffs)

trunk/src/wp-content/themes/twentytwelve/functions.php

@@ -502 +502 @@
 
                 /* translators: Used between list items, there is a space after the comma. */
-                $tag_list = get_the_tag_list( '', __( ', ', 'twentytwelve' ) );
+                $tags_list = get_the_tag_list( '', __( ', ', 'twentytwelve' ) );
 
                 $date = sprintf(
@@ -520 +520 @@
                 );
 
-                if ( $tag_list ) {
+                if ( $tags_list && ! is_wp_error( $tags_list ) ) {
                         /* translators: 1: Category name, 2: Tag name, 3: Date, 4: Author display name. */
                         $utility_text = __( 'This entry was posted in %1$s and tagged %2$s on %3$s<span class="by-author"> by %4$s</span>.', 'twentytwelve' );
@@ -534 +534 @@
                         $utility_text,
                         $categories_list,
-                        $tag_list,
+                        $tags_list,
                         $date,
                         $author