WordPress.org

Make WordPress Core

Changeset 47910


Ignore:
Timestamp:
06/04/2020 03:46:00 PM (6 months ago)
Author:
desrosj
Message:

Accessibility: Add the aria-hidden attribute to the auto-update related icons.

<span> elements used for displaying icons should use the aria-hidden attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

Location:
trunk/src/wp-admin
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

    r47894 r47910  
    749749        );
    750750
    751         echo '<span class="dashicons dashicons-update spin hidden"></span>';
     751        echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
    752752        echo '<span class="label">' . $text . '</span>';
    753753        echo '</a>';
  • trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

    r47894 r47910  
    10671067                    );
    10681068
    1069                     echo '<span class="dashicons dashicons-update spin hidden"></span>';
     1069                    echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
    10701070                    echo '<span class="label">' . $text . '</span>';
    10711071                    echo '</a>';
  • trunk/src/wp-admin/themes.php

    r47848 r47910  
    633633                <# if ( data.autoupdate ) { #>
    634634                    <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
    635                         <span class="dashicons dashicons-update spin hidden"></span>
     635                        <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
    636636                        <span class="label"><?php _e( 'Disable auto-updates' ); ?></span>
    637637                    </a>
    638638                <# } else { #>
    639639                    <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
    640                         <span class="dashicons dashicons-update spin hidden"></span>
     640                        <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
    641641                        <span class="label"><?php _e( 'Enable auto-updates' ); ?></span>
    642642                    </a>
Note: See TracChangeset for help on using the changeset viewer.