Changeset 47910

Timestamp:

06/04/2020 03:46:00 PM (5 years ago)

Author:

desrosj

Message:

Accessibility: Add the aria-hidden attribute to the auto-update related icons.

<span> elements used for displaying icons should use the aria-hidden attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-ms-themes-list-table.php (modified) (1 diff)
• includes/class-wp-plugins-list-table.php (modified) (1 diff)
• themes.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -749 +749 @@
         );
 
-        echo '<span class="dashicons dashicons-update spin hidden"></span>';
+        echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
         echo '<span class="label">' . $text . '</span>';
         echo '</a>';

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -1067 +1067 @@
                     );
 
-                    echo '<span class="dashicons dashicons-update spin hidden"></span>';
+                    echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
                     echo '<span class="label">' . $text . '</span>';
                     echo '</a>';

trunk/src/wp-admin/themes.php

@@ -633 +633 @@
                 <# if ( data.autoupdate ) { #>
                     <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
-                        <span class="dashicons dashicons-update spin hidden"></span>
+                        <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
                         <span class="label"><?php _e( 'Disable auto-updates' ); ?></span>
                     </a>
                 <# } else { #>
                     <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
-                        <span class="dashicons dashicons-update spin hidden"></span>
+                        <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
                         <span class="label"><?php _e( 'Enable auto-updates' ); ?></span>
                     </a>