Changeset 47911 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

06/04/2020 04:41:47 PM (4 years ago)

Author:

whyisjake

Message:

REST API: Ensure that all properties of get_endpoint_args_for_item_schema are listed.

• Add new var $valid_schema_properties to match rest_validate_value_from_schema()
• Unit test to ensure all valid properties exists, and non-valid properties are ignored

Fixes: #50301.
Props: pentatonicfunk, TimothyBlynJacobs.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -627 +627 @@
     public function get_endpoint_args_for_item_schema( $method = WP_REST_Server::CREATABLE ) {
 
-        $schema            = $this->get_item_schema();
-        $schema_properties = ! empty( $schema['properties'] ) ? $schema['properties'] : array();
-        $endpoint_args     = array();
+        $schema                  = $this->get_item_schema();
+        $schema_properties       = ! empty( $schema['properties'] ) ? $schema['properties'] : array();
+        $endpoint_args           = array();
+        $valid_schema_properties = array(
+            'type',
+            'format',
+            'enum',
+            'items',
+            'properties',
+            'additionalProperties',
+            'minimum',
+            'maximum',
+            'exclusiveMinimum',
+            'exclusiveMaximum',
+            'minLength',
+            'maxLength',
+            'pattern',
+        );
 
         foreach ( $schema_properties as $field_id => $params ) {
@@ -655 +670 @@
             }
 
-            foreach ( array( 'type', 'format', 'enum', 'items', 'properties', 'additionalProperties' ) as $schema_prop ) {
+            foreach ( $valid_schema_properties as $schema_prop ) {
                 if ( isset( $params[ $schema_prop ] ) ) {
                     $endpoint_args[ $field_id ][ $schema_prop ] = $params[ $schema_prop ];