Changeset 47911 for trunk/tests/phpunit/tests/rest-api/rest-controller.php

Timestamp:

06/04/2020 04:41:47 PM (4 years ago)

Author:

whyisjake

Message:

REST API: Ensure that all properties of get_endpoint_args_for_item_schema are listed.

• Add new var $valid_schema_properties to match rest_validate_value_from_schema()
• Unit test to ensure all valid properties exists, and non-valid properties are ignored

Fixes: #50301.
Props: pentatonicfunk, TimothyBlynJacobs.

File:

• trunk/tests/phpunit/tests/rest-api/rest-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-controller.php

@@ -246 +246 @@
 
         $this->assertEquals( 'a', $args['somedefault']['default'] );
+    }
+
+    /**
+     * @ticket 50301
+     */
+    public function test_get_endpoint_args_for_item_schema_arg_properties() {
+
+        $controller = new WP_REST_Test_Controller();
+        $args       = $controller->get_endpoint_args_for_item_schema();
+
+        foreach ( array( 'minLength', 'maxLength', 'pattern' ) as $property ) {
+            $this->assertArrayHasKey( $property, $args['somestring'] );
+        }
+
+        foreach ( array( 'minimum', 'maximum', 'exclusiveMinimum', 'exclusiveMaximum' ) as $property ) {
+            $this->assertArrayHasKey( $property, $args['someinteger'] );
+        }
+
+        $this->assertArrayHasKey( 'items', $args['somearray'] );
+
+        foreach ( array( 'properties', 'additionalProperties' ) as $property ) {
+            $this->assertArrayHasKey( $property, $args['someobject'] );
+        }
+
+        // ignored properties
+        $this->assertArrayNotHasKey( 'ignored_prop', $args['someobject'] );
+
     }
 
@@ -268 +295 @@
                 'someargoptions',
                 'somedefault',
+                'somearray',
+                'someobject',
             ),
             $fields
@@ -299 +328 @@
                     'someargoptions',
                     'somedefault',
+                    'somearray',
+                    'someobject',
                 ),
             ),