Changeset 47926 for trunk/src/xmlrpc.php

Timestamp:

06/08/2020 07:53:19 PM (4 years ago)

Author:

desrosj

Message:

General: Remove or add inline comments to $HTTP_RAW_POST_DATA occurrences.

The $HTTP_RAW_POST_DATA global was deprecated in PHP 5.6 and removed completely in PHP 7.0. In general, php://input should be used instead of $HTTP_RAW_POST_DATA.

Because WordPress Core still supports PHP 5.6, some plugins or sites may still rely on this variable being present and populated with the expected data. For that reason, occurrences of the variable will remain with updated inline documentation until support for PHP 5.6 is officially dropped in WordPress.

Props skoskie, jrf, desrosj, TimothyBlynJacobs.
See #49922.
Fixes #49810.

File:

• trunk/src/xmlrpc.php (modified) (2 diffs)

trunk/src/xmlrpc.php

@@ -16 +16 @@
 $_COOKIE = array();
 
-// A bug in PHP < 5.2.2 makes $HTTP_RAW_POST_DATA not set by default,
-// but we can do it ourself.
+// $HTTP_RAW_POST_DATA was deprecated in PHP 5.6 and removed in PHP 7.0.
+// phpcs:disable PHPCompatibility.Variables.RemovedPredefinedGlobalVariables.http_raw_post_dataDeprecatedRemoved
 if ( ! isset( $HTTP_RAW_POST_DATA ) ) {
     $HTTP_RAW_POST_DATA = file_get_contents( 'php://input' );
@@ -26 +26 @@
     $HTTP_RAW_POST_DATA = trim( $HTTP_RAW_POST_DATA );
 }
+// phpcs:enable
 
 /** Include the bootstrap for setting up WordPress environment */