Changeset 47929

Timestamp:

06/08/2020 09:25:46 PM (3 years ago)

Author:

desrosj

Message:

Coding Standards: PHP short ternary operator syntax is not allowed.

WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.

Follow up of [47927].
Fixes #50258.

Location:

trunk/src

Files:

• wp-admin/includes/translation-install.php (modified) (2 diffs)
• wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php (modified) (1 diff)

trunk/src/wp-admin/includes/translation-install.php

@@ -176 +176 @@
                 esc_attr( $language['language'] ),
                 esc_attr( current( $language['iso'] ) ),
-                esc_attr( $language['strings']['continue'] ?: 'Continue' ),
+                esc_attr( $language['strings']['continue'] ? $language['strings']['continue'] : 'Continue' ),
                 in_array( $language['language'], $installed_languages, true ) ? ' data-installed="1"' : '',
                 esc_html( $language['native_name'] )
@@ -190 +190 @@
             esc_attr( $language['language'] ),
             esc_attr( current( $language['iso'] ) ),
-            esc_attr( $language['strings']['continue'] ?: 'Continue' ),
+            esc_attr( $language['strings']['continue'] ? $language['strings']['continue'] : 'Continue' ),
             in_array( $language['language'], $installed_languages, true ) ? ' data-installed="1"' : '',
             esc_html( $language['native_name'] )

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php

@@ -145 +145 @@
         if ( rest_is_field_included( 'screenshot', $fields ) ) {
             // Using $theme->get_screenshot() with no args to get absolute URL.
-            $data['screenshot'] = $theme->get_screenshot() ?: '';
+            $data['screenshot'] = $theme->get_screenshot() ? $theme->get_screenshot() : '';
         }